Add telemetry events #304

bsudekum · 2017-06-22T12:51:59Z

~~Telem events manager needs to be made public first: https://github.com/mapbox/mapbox-gl-native/tree/bs-telem-api~~ -> https://github.com/mapbox/mapbox-telemetry-ios

This PR adds the ground work for telemetry events and also adds the first event, rerouting. On every reroute, an event will be pushed to the event manager containing the last 20 locations prior to the reroute and up to 20 locations after the reroute. The event manager in the iOS SDK will then push all events in a single network request to the server.

The goal here is help improve all aspects of the navigation SKD and also the directions API which this SDK relies on.

/cc @1ec5 @ericrwolfe @frederoni

bsudekum · 2017-06-22T12:52:45Z

MapboxCoreNavigation/RouteController.swift

+            locationDictionary["lat"] = location.coordinate.latitude
+            locationDictionary["lng"] = location.coordinate.latitude
+            locationDictionary["altitude"] = location.altitude
+            locationDictionary["timestamp"] = location.timestamp


For some reason, I'm unable to todo location.timestamp.ISO8601 here even though location.timestamp is of type Date

Drop static from ISO8601 and return formatter.string(from: self) should work.

bsudekum · 2017-06-22T12:53:04Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+        modifiedEventDictionary["platform"] = UIDevice.current.systemName
+        modifiedEventDictionary["operatingSystemVersion"] = "\(UIDevice.current.systemName)-\(UIDevice.current.systemVersion)"
+        modifiedEventDictionary["sdkIdentifier"] = "mapbox-navigation-ios"
+        modifiedEventDictionary["sdkVersion"] = "0.4.0"


There should be a better way to do this.

Something like: Bundle.navigationUI.object(forInfoDictionaryKey: "CFBundleShortVersionString"). There should be a constant for CFBundleShort… IIRC

frederoni · 2017-06-22T15:45:42Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+    class func addDefaultEvents(routeProgress: RouteProgress, sessionIdentifier: UUID) -> [String: Any] {
+        var modifiedEventDictionary: [String: Any] = [:]
+
+        modifiedEventDictionary["platform"] = UIDevice.current.systemName


UIDevice should be part of UIKit which this library doesn't depend on. 😕
We should adapt this for watchOS later.

Are there any alternatives?

We can wrap this in a compiler flag by platform and by default we can set this to unknown

E.g.

#if os(iOS) UIApplication.shared.isIdleTimerDisabled = true #endif

This library is currently only being built for iOS, so #if os(iOS) is unnecessary. The issue is actually that Core Navigation avoids depending on UIKit. We should add a hook for MapboxNavigation to add to this dictionary.

frederoni · 2017-06-22T16:17:56Z

MapboxCoreNavigation/RouteController.swift

@@ -161,6 +184,20 @@ extension RouteController: CLLocationManagerDelegate {
            return
        }

+        userLocationForRerouteEvent.append(location)
+        // Keep double the amount needed for reroute event since we keep collecting after the reroute
+        if userLocationForRerouteEvent.count >= rerouteLocationArraySize * 20 {


Should this be * 2?

ericrwolfe · 2017-06-22T17:11:03Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+    class func addDefaultEvents(routeProgress: RouteProgress, sessionIdentifier: UUID) -> [String: Any] {
+        var modifiedEventDictionary: [String: Any] = [:]
+
+        modifiedEventDictionary["platform"] = UIDevice.current.systemName


We can wrap this in a compiler flag by platform and by default we can set this to unknown

E.g.

#if os(iOS) UIApplication.shared.isIdleTimerDisabled = true #endif

ericrwolfe · 2017-06-22T17:12:48Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+
+        modifiedEventDictionary["platform"] = UIDevice.current.systemName
+        modifiedEventDictionary["operatingSystemVersion"] = "\(UIDevice.current.systemName)-\(UIDevice.current.systemVersion)"
+        modifiedEventDictionary["sdkIdentifier"] = "mapbox-navigation-ios"


Would there be an easy way to differentiate this between MapboxCoreNavigation (mapbox-navigation-ios) and MapboxNavigation (mapbox-navigation-ios-ui)?

This gets tricky. We could pass the event object along in the didreroute method and then have UI send off the event. But it's impossible for core to know whether UI is actually used. I think we might have to punt on this for now.

It isn’t impossible: see the ideas in mapbox/mapbox-directions-swift#136, specifically NSClassFromString(_:) and Bundle(for:).

Even more straightforward would be for Core Navigation to expose a hook for MapboxNavigation to tell Core Navigation that it’s present.

ericrwolfe · 2017-06-22T17:16:57Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+        var newDictionary: [String: Any] = [:]
+
+        for key in Array(eventDictionary.keys) {
+            newDictionary["\(eventPrefix)"] = eventDictionary[key]


I'm not sure I follow the purpose or logic of this function? It looks like here the resulting dictionary will always have only a single key:

[ "eventPrefix": <random value> ]

ericrwolfe · 2017-06-22T17:21:37Z

MapboxCoreNavigation/RouteController.swift

+    var countdownToPushEvent = 20
+    var distanceCompleted: CLLocationDistance = 0
+    var distanceRemaining: CLLocationDistance?
+    var durationRemaining: TimeInterval?


Should we rename these to lastRerouteDistanceRemaining or something to clarify that these properties are stored state from the last reroute? Or should we put these all into a single struct property for the last reroute state?

Something like

struct LastRerouteState { var distanceRemaining: CLLocationDistance var durationRemaining: CLLocationDistance ...etc... }

ericrwolfe · 2017-06-22T17:22:58Z

MapboxCoreNavigation/RouteController.swift

+        eventDictionary["feedbackType"] = "reroute"
+        eventDictionary["locationsBefore"] = convertLocastionsObject(locations: Array(userLocationForRerouteEvent.prefix(rerouteIndexLocationBefore)))
+        eventDictionary["locationsAfter"] = convertLocastionsObject(locations: Array(userLocationForRerouteEvent.suffix(from: rerouteIndexLocationBefore)))
+        eventDictionary["userLocatioBeforeAfterReroute"] = userLocationForRerouteEvent


This property isn't in the spec so the event may be discarded by the API. What's the thought behind including this?

Oh this is old code prior to spec outline.

ericrwolfe · 2017-06-22T17:23:59Z

MapboxCoreNavigation/RouteController.swift

+        eventDictionary["distanceRemaining"] = distanceRemaining ?? nil
+        eventDictionary["durationRemaining"] = durationRemaining ?? nil
+
+        let eventDictionaryWithPrefix = MGLMapboxEvents.addEventPrefix(eventDictionary: eventDictionary, eventPrefix: "navigation.reroute")


We shouldn't need to prefix the event attribute keys with the event name.

ericrwolfe · 2017-06-22T17:24:42Z

MapboxCoreNavigation/RouteController.swift

@@ -393,4 +464,20 @@ extension RouteController: CLLocationManagerDelegate {

        incrementRouteProgress(alertLevel, location: location, updateStepIndex: updateStepIndex)
    }
+
+    func convertLocastionsObject(locations: [CLLocation]) -> [[String: Any]] {


Typo convertLocastionsObject

bsudekum · 2017-06-23T10:08:29Z

MapboxCoreNavigation/String.swift

@@ -0,0 +1,20 @@
+import UIKit


@frederoni you think this okay? I can't use UIDevice.current.systemName without it. You think hardcoding strings would be okay here?

You should do something like:

#if os(iOS) import UIKit #elseif os(watchOS) import WatchKit

However, that could be tail work or part of #305

bsudekum · 2017-06-23T11:13:12Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+import Polyline
+
+extension MGLMapboxEvents {
+    public class func addDefaultEvents(routeProgress: RouteProgress, sessionIdentifier: UUID, sessionNumberOfReroutes: Int = 0) -> [String: Any] {


Is there any way we can share this function with MapboxNavigation without making it public? We need it for navigation.cancel

Not really, because MapboxCoreNavigation and MapboxNavigation are separate modules. If you were to declare this method in an Objective-C header but implement it in Swift, it would be possible to give the header “private” membership in the MapboxCoreNavigation target, which would make it accessible to other targets in the same Xcode project, like MapboxNavigation. At least that’s true in Xcode and Carthage land. I don’t think that would work with CocoaPods.

bsudekum · 2017-06-23T11:13:49Z

MapboxCoreNavigation/RouteController.swift

+    /**
+     IOS 8601 timestamp of when the `RouteController` was initialized.
+     */
+    public let sessionStartTimestamp: String = Date().ISO8601


Same question as in https://github.com/mapbox/mapbox-navigation-ios/pull/304/files#r123724999, can make this sharable with MapboxNavigation but not public?

bsudekum · 2017-06-23T11:14:40Z

Added remaining events, cancel, arrive, depart in 9a65dbf

frederoni · 2017-06-23T14:09:47Z

Looks good. It's mostly the private communication between core and the ui that we probably should solve. Perhaps a test case to verify the circular buffer and break out the collection of locations from locationManager(_:didUpdateLocations:) into a separate function (enqueue(location:)).

1ec5 · 2017-06-29T03:26:25Z

MapboxCoreNavigation/Date.swift

@@ -0,0 +1,9 @@
+extension Date {
+    var ISO8601: String {


Too bad ISO8601DateFormatter is only in iOS 10.0 and above.

1ec5 · 2017-06-29T03:32:11Z

MapboxCoreNavigation/Feedback.swift

+import Foundation
+
+public enum FeedbackType: String {
+    case general = "general"


As of Swift 3.1, string enumerations only bridge from Objective-C to Swift, not the other way around. Since Objective-C clients don’t need to access the underlying strings, the usual pattern is to have the enumeration be backed by Int and conform to CustomStringConvertible (example).

Since this enum will not public, is it required to make it bridge-compatible?

It is public – should it be?

It’s currently impossible for an Objective-C application to call RouteController.recordFeedback(type:description:) et al., because this public type doesn’t bridge to Objective-C.

1ec5 · 2017-06-29T04:15:31Z

MapboxCoreNavigation/RouteController.swift

+        NSLog("Sending \(eventName)")
+
+        event.eventDictionary["locationsBefore"] = sessionState.pastLocations.allObjects.filter({$0.timestamp <= event.timestamp }).map({$0.dictionary})
+        event.eventDictionary["locationsAfter"] = sessionState.pastLocations.allObjects.filter({$0.timestamp > event.timestamp }).map({$0.dictionary})


Nit: Use trailing closure syntax.

1ec5 · 2017-06-29T04:17:06Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+    }
+}
+
+class CoreFeedbackEvent: Hashable {


If neither this class nor any of its subclasses need to be public (to Objective-C code), we should make them structs. Swift will synthesize initializers for these structs, they’ll take up less memory, and they’re just easier to work with than value classes.

CoreFeedbackEvent was originally a struct until we split out feedback into two separate event types. Structs don't support inheritance, thus the switch.

Ah, in that case protocols are typically used for code sharing between struct types. However, there’s no structural difference between the two subclasses. If we expect the two types of events to diverge in the future, we can have two structs conform to a single protocol, or we can use an enumeration with associated values instead of a struct. Otherwise, a simple enumeration-typed property inside the struct would suffice.

1ec5 · 2017-06-29T04:18:35Z

MapboxCoreNavigation/RouteController.swift

+
+        eventDictionary["secondsSinceLastReroute"] = sessionState.lastReroute != nil ? round(timestamp.timeIntervalSince(sessionState.lastReroute!)) : -1
+
+        // These are placeholders until the


Nit: trailing thought. 💭

1ec5 · 2017-06-29T04:21:31Z

MapboxCoreNavigation/RouteController.swift

+            if let geometry = route.coordinates {
+                lastReroute.eventDictionary["newGeometry"] = Polyline(coordinates: geometry).encodedPolyline
+                lastReroute.eventDictionary["newDistanceRemaining"] = round(route.distance)
+                lastReroute.eventDictionary["newDurationRemaining"] = round(route.expectedTravelTime)


A [String: Any] using string literals for the keys can be rather fragile, especially for code that lacks unit tests. Let’s replace eventDictionary with strongly-typed properties for each of the expected fields, then add a method to CoreFeedbackEvent or RerouteEvent that converts to an attributes dictionary.

Would it be possible to add some tests for at least the event generation? The spec may change a lot still so relying on tests may actually make more sense at this point (or always).

Using stronger typing with FeedbackEvent will ensure better test coverage. In essence, we need to centralize the logic that converts from native types like Polyline into JSON types, rather than scattering that logic in multiple places, as is the case right now.

There still aren’t any tests of the new feature. Some of the other feedback, such as #304 (comment), would no doubt be caught by basic tests.

1ec5 · 2017-06-29T04:23:26Z

MapboxCoreNavigation/RouteController.swift

+
+        let eventName = event.eventDictionary["event"] as! String
+
+        NSLog("Sending \(eventName)")


Nit: print() is more idiomatic than NSLog() in Swift.

1ec5 · 2017-06-29T04:24:27Z

MapboxCoreNavigation/RouteController.swift

+
+        let eventName = event.eventDictionary["event"] as! String
+
+        NSLog("Sending \(eventName)")


Remove any print statements before merging. If these print statements are really needed for debugging, we should make them debug-only, either using a compiler flag or perhaps a user default.

1ec5 · 2017-06-29T04:27:41Z

MapboxCoreNavigation/String.swift

+extension String {
+    static var systemName: String {
+        #if os(iOS) || os(tvOS)
+            return UIDevice.current.systemName


Doesn’t this just return “iOS” or “tvOS”?

1ec5 · 2017-06-29T04:31:08Z

MapboxCoreNavigation/MGLMapboxEvents.swift

+            var systemInfo = utsname()
+            uname(&systemInfo)
+            let machineMirror = Mirror(reflecting: systemInfo.machine)
+            let identifier = machineMirror.children.reduce("") { identifier, element in


How does this dark magic differ from the telemetry library implementation, which is also currently used in the map SDK?

It's basically the same. Many of these duplicated class extensions are just stopgaps until we can leverage the full standalone telemetry framework.

bsudekum · 2017-07-17T22:56:29Z

@frederoni @1ec5 this is ready for another round of review.

1ec5 · 2017-07-19T08:12:08Z

MapboxCoreNavigation/MMEEventsManager.swift

+        sdkIdentifier = routeController.usesDefaultUserInterface ? "mapbox-navigation-ui-ios" : "mapbox-navigation-ios"
+        sdkVersion = String(describing: Bundle(for: RouteController.self).object(forInfoDictionaryKey: "CFBundleShortVersionString")!)
+
+        eventVersion = 2


All the events produced by a particular version of this library should have the same version, right? Let’s make sure that’s the case by pulling this value out into a constant. No need for a property on the struct; just use the constant in convertedToDictionary().

Also, I don't think this value is actually used currently. convertedToDictionary() currently sets the value with a literal value.

1ec5 · 2017-07-19T08:15:04Z

MapboxCoreNavigation/MMEEventsManager.swift

+
+        platform = ProcessInfo.systemName
+        operatingSystem = "\(ProcessInfo.systemName) \(ProcessInfo.systemVersion)"
+        device = UIDevice.current.machine


platform, operatingSystem, sdkVersion, etc. can never change throughout the session, so set them in convertedToDictionary() rather than increasing the size of the struct. The fewer properties in the struct, the smaller each instance of the struct and the higher likelihood that Swift will use an efficient memory representation for it.

1ec5 · 2017-07-19T08:18:01Z

MapboxCoreNavigation/MMEEventsManager.swift

+    var estimatedDuration: TimeInterval?
+    var stepCount: Int?
+    var created: Date
+    var startTimestamp: String?


This should be a Date, like created. Wait until convertedToDictionary() to lazily convert it to a string.

1ec5 · 2017-07-19T08:19:05Z

MapboxCoreNavigation/MMEEventsManager.swift

+        applicationState = UIApplication.shared.applicationState.telemetryString
+    }
+
+    func convertedToDictionary() -> [String: Any] {


var eventDictionary or var jsonDictionary would be more descriptive.

1ec5 · 2017-07-19T08:19:51Z

MapboxCoreNavigation/MMEEventsManager.swift

+    var screenBrightness: Int
+    var batteryPluggedIn: Bool
+    var batteryLevel: Float
+    var applicationState: String


This should be a UIApplicationState. Wait until convertedToDictionary() to lazily convert it to a string.

1ec5 · 2017-07-19T08:29:23Z

MapboxCoreNavigation/RouteController.swift

+     */
+    public func updateLastFeedback(type: FeedbackType, description: String?) {
+        if let lastFeedback = outstandingFeedbackEvents.filter({$0 is FeedbackEvent}).last {
+            lastFeedback.eventDictionary["feedbackType"] = type.rawValue


FeedbackType.rawValue is an integer (e.g., 0 for general). Did you mean to set this item to type.description instead?

1ec5 · 2017-07-19T08:31:57Z

MapboxCoreNavigation/RouteController.swift

+            if let geometry = route.coordinates {
+                lastReroute.eventDictionary["newGeometry"] = Polyline(coordinates: geometry).encodedPolyline
+                lastReroute.eventDictionary["newDistanceRemaining"] = round(route.distance)
+                lastReroute.eventDictionary["newDurationRemaining"] = round(route.expectedTravelTime)


There still aren’t any tests of the new feature. Some of the other feedback, such as #304 (comment), would no doubt be caught by basic tests.

1ec5 · 2017-07-19T08:33:21Z

MapboxCoreNavigation/RouteController.swift

+    var currentRoute: Route!
+    var currentRequestIdentifier: String?
+
+    var originalRoute: Route!


Implicitly unwrapped optionals are unsafe. Make this property and currentRoute non-optional and pass them in when initializing the SessionState below.

1ec5 · 2017-07-19T08:34:09Z

MapboxCoreNavigation/RouteController.swift

+struct SessionState {
+    let identifier = UUID()
+    var departureTimestamp: Date?
+    var arrivalTimestamp: Date?


Can we call these dates instead of timestamps? They are Dates, after all.

1ec5 · 2017-07-19T08:35:02Z

MapboxCoreNavigation/RouteController.swift

+    var totalDistanceCompleted: CLLocationDistance = 0
+
+    var numberOfReroutes = 0
+    var lastReroute: Date?


lastRerouteDate would be clearer; otherwise, one could reasonably see lastReroute somewhere in the code and think it refers to a coordinate.

boundsj · 2017-07-19T15:42:18Z

MapboxCoreNavigation/RouteController.swift

+
+        if let mapboxAccessToken = mapboxAccessToken {
+            events.isDebugLoggingEnabled = true
+            events.isMetricsEnabledInSimulator = true


I don't think we should ship this with metrics enabled in simulator set to true. Maybe this library can define a new user default key (it would not need to be documented) that could be checked and this value could default to false and and use the value in user defaults if available?

ericrwolfe · 2017-07-20T00:35:52Z

@bsudekum good for a final review then I think we're ready to merge

bsudekum · 2017-07-20T17:20:46Z

This is blocked by putting out a new release of MapboxDirections.swift which includes mapbox/mapbox-directions-swift#155.

Waiting on mapbox/mapbox-directions-swift#154 also.

1ec5 · 2017-07-21T08:30:18Z

Cartfile

@@ -1,5 +1,5 @@
 binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" ~> 3.5
-github "mapbox/MapboxDirections.swift" ~> 0.10.0
+github "mapbox/MapboxDirections.swift" ~> 0.10


Since MapboxDirections.swift hasn’t yet reached v1.0, anything could technically change at any time. We do try to avoid backwards-compatible changes in patch releases, but we make no such guarantees about minor releases.

We should pin to a specific patch version of the library (with the tadpole operator) to avoid surprises. ~> 0.10.1 will require v0.10.x except v0.10.0.

1ec5 · 2017-07-21T08:34:42Z

MapboxCoreNavigation/MMEEventsManager.swift

+        return EventDetails(routeController: routeController, session: routeController.sessionState).eventDictionary
+    }
+
+    func navigationDepartEvent(routeController: RouteController) -> [String: Any] {


Instead of a series of separate methods that each sets a different event value, we should have a single method that takes an MMEEventType as a parameter; depending on the passed-in eventType, we can add additional items to eventDictionary as needed.

* master: Reroute using access token and host used to create request (#405) Update osrm-text-instruction, MapboxDirections.swift (#404) # Conflicts: # Cartfile.resolved # MapboxCoreNavigation.podspec

1ec5 · 2017-07-24T21:35:45Z

MapboxNavigation/NavigationViewController.swift

@@ -195,6 +195,12 @@ public class NavigationViewController: NavigationPulleyViewController, RouteMapV
     */
    public var sendNotifications: Bool = true

+    public var showsReportFeedback: Bool = false {


This method needs documentation.

bsudekum commented Jun 22, 2017

View reviewed changes

bsudekum requested review from 1ec5, frederoni and ericrwolfe June 22, 2017 14:05

frederoni reviewed Jun 22, 2017

View reviewed changes

ericrwolfe reviewed Jun 22, 2017

View reviewed changes

bsudekum commented Jun 23, 2017

View reviewed changes

bsudekum changed the title ~~Add reroute telemetry event~~ Add telemetry events Jun 23, 2017

Bobby Sudekum added 8 commits June 26, 2017 17:19

Begin adding telem events

3215921

fix

4f85bdf

add timezone

530ae77

Update

cff594f

Add remaining events

3b05ad0

conditional import

6fa8b98

Move back to core

8b61ab9

make private

a1ac9cd

ericrwolfe force-pushed the telem branch from a3e311c to 53cb816 Compare June 27, 2017 00:27

Consolidate telemetry state, outline full telemetry spec

4170144

ericrwolfe force-pushed the telem branch from 53cb816 to 4170144 Compare June 27, 2017 00:28

ericrwolfe added 4 commits June 28, 2017 10:50

Update date format

7c19139

Store more state; add device

ae3606f

Updated telemetry event handling

582801f

Round events

e9ab2d3

1ec5 reviewed Jun 29, 2017

View reviewed changes

Add dialog view controller

c48a740

frederoni force-pushed the telem branch from 1e91e51 to 12a51b4 Compare July 18, 2017 16:20

Merge branch 'master' into telem

24440b5

ericrwolfe added this to the v0.6.0-1 milestone Jul 19, 2017

ericrwolfe added the topic: telemetry label Jul 19, 2017

1ec5 reviewed Jul 19, 2017

View reviewed changes

boundsj reviewed Jul 19, 2017

View reviewed changes

Bobby Sudekum and others added 9 commits July 19, 2017 10:34

Update

3d5b8ef

No telem in sim

d72d8b3

add back

a013625

Dont pass in access token

cd42c00

fix

c90e03e

Switch to nested step dictionary in feedback events

90b18a9

Add debug metrics user info key

621c2f4

Fix feedback event types

572cde4

Moved all event dictionary generation to MMEEventsManager

e04bb09

Move feedback event dict update logic

bf2e536

Bump

1a07311

1ec5 reviewed Jul 21, 2017

View reviewed changes

ericrwolfe added 2 commits July 21, 2017 11:48

Merge branch 'master' into telem

5dec73b

* master: Reroute using access token and host used to create request (#405) Update osrm-text-instruction, MapboxDirections.swift (#404) # Conflicts: # Cartfile.resolved # MapboxCoreNavigation.podspec

Pin to MapboxDirections.swift 0.10.1

a7b8e1a

ericrwolfe approved these changes Jul 21, 2017

View reviewed changes

ericrwolfe merged commit daaa324 into master Jul 21, 2017

1ec5 reviewed Jul 24, 2017

View reviewed changes

JThramer deleted the telem branch September 7, 2018 20:34

1ec5 mentioned this pull request Jan 10, 2020

Require map SDK v5.6.0 #2302

Merged

1ec5 mentioned this pull request Sep 30, 2022

Utilize Events API from Common SDK #4011

Merged


		eventDictionary["secondsSinceLastReroute"] = sessionState.lastReroute != nil ? round(timestamp.timeIntervalSince(sessionState.lastReroute!)) : -1

		// These are placeholders until the


		let eventName = event.eventDictionary["event"] as! String

		NSLog("Sending \(eventName)")

Add telemetry events #304

Add telemetry events #304

Conversation

bsudekum commented Jun 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jun 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Jun 23, 2017

frederoni commented Jun 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jun 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Jul 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericrwolfe commented Jul 20, 2017

bsudekum commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Jun 22, 2017 •

edited

Loading

1ec5 Jun 22, 2017 •

edited

Loading

1ec5 Jun 29, 2017 •

edited

Loading

1ec5 Jul 19, 2017 •

edited

Loading

1ec5 Jul 19, 2017 •

edited

Loading