Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update String resources with new Transifex translations #889

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

danesfeder
Copy link
Contributor

Closes #888

We also had uploaded test app strings being used as keys, which are not translatable. I marked them as such here.

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments lie... 👀 https://github.com/mapbox/mapbox-navigation-android/pull/889/files#diff-79501bd1c71d26dd2207bbd5af379e00L6

"Code never lies, comments sometimes do."
- Ron Jeffries pic.twitter.com/tXk0fXgN5Z

— The Practical Dev (@thepracticaldev) April 22, 2018

Let's remove them 🙏
IMO, they're not giving any value here, the string name reflects their purpose perfectly.

@1ec5
Copy link
Contributor

1ec5 commented Apr 26, 2018

Let's remove them 🙏
IMO, they're not giving any value here, the string name reflects their purpose perfectly.

I disagree, because the key is machine-readable, whereas the comment is human-readable. Transifex displays the comment prominently in the translation UI. The key is more obscure, and translators often have no clue what the key means out of context.

If the comments aren’t providing any value, then consider improving the comments to explain the differences between each feedback type and where the string appears in the UI. For example, is it a label on a button? Are there any length constraints? Should it be translated as a command (verb)?

@danesfeder danesfeder merged commit 279c7b2 into master Apr 27, 2018
@danesfeder danesfeder deleted the dan-update-tx branch April 27, 2018 12:37
@1ec5
Copy link
Contributor

1ec5 commented Apr 27, 2018

@danesfeder, remember to update localization.md to reflect these changes. Thanks! (This guide should also mention updating that document.)

@Guardiola31337
Copy link
Contributor

Transifex displays the comment prominently in the translation UI. The key is more obscure, and translators often have no clue what the key means out of context.

Didn't know that Transifex displayed the comments somehow to translators (that's awesome 🎉).
As this is the case, yeah I agree, let's keep them and as @1ec5 mentioned let's try to update them so they provide the most value.

@danesfeder danesfeder mentioned this pull request May 3, 2018
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants