Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation #888

Closed
tan-tran-viet-xx opened this issue Apr 26, 2018 · 4 comments
Closed

Korean translation #888

tan-tran-viet-xx opened this issue Apr 26, 2018 · 4 comments

Comments

@tan-tran-viet-xx
Copy link

Hi team,

I have translated all strings into Korean (ko)

https://www.transifex.com/mapbox/mapbox-gl-native/language/ko/
https://www.transifex.com/mapbox/mapbox-navigation-sdk-for-android/language/ko/
https://www.transifex.com/mapbox/mapbox-navigation-ios/language/ko/

Also I have translated all OSRM strings:
Project-OSRM/osrm-text-instructions#241

Please help me review and let me know if I need to change anything
Hopefully the translation will be merged soon

Thanks.

@danesfeder
Copy link
Contributor

Hey @tan-tran-ea, thanks for the work here! I pulled in the new translations from Transifex in #889. If you want to take a look and see if it checks out, that would be great.

@1ec5
Copy link
Contributor

1ec5 commented Apr 26, 2018

I pulled your translations of OSRM Text Instructions into Project-OSRM/osrm-text-instructions#243. Please have a look at that as well. Thanks!

@tan-tran-viet-xx
Copy link
Author

Thanks @danesfeder , @1ec5

Also please help me pull the translations for Mapbox Navigation iOS and Mapbox GJ Native. I have translated all strings (excluded sample app)

Thanks so much

@1ec5
Copy link
Contributor

1ec5 commented Apr 27, 2018

Also please help me pull the translations for Mapbox Navigation iOS and Mapbox GJ Native. I have translated all strings (excluded sample app)

Thanks, pulling these translations in mapbox/mapbox-navigation-ios#1346 and mapbox/mapbox-gl-native#11792. Note that, although Project-OSRM/osrm-text-instructions#243 has been merged, we’ll need to release OSRMTI and deploy it as part of the Directions API before you’ll be able to receive instructions in Korean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants