Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations to latest Transifex #2003

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Jul 18, 2019

Description

Updates translations to latest Transifex

Fixes #2000

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Get newest and latest translations available in Transifex

Implementation

Pull translations from Transifex and add them to the SDK and test app

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR
  • Any changes to strings have been published to our translation tool

cc @toblinkz

@codecov-io
Copy link

Codecov Report

Merging #2003 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2003   +/-   ##
=========================================
  Coverage     41.61%   41.61%           
  Complexity     1290     1290           
=========================================
  Files           288      288           
  Lines          9209     9209           
  Branches        682      682           
=========================================
  Hits           3832     3832           
  Misses         5060     5060           
  Partials        317      317

@Guardiola31337 Guardiola31337 merged commit 3d1c6a6 into master Jul 18, 2019
@Guardiola31337 Guardiola31337 deleted the pg-2000-yoruba-tx branch July 18, 2019 18:29
@toblinkz toblinkz mentioned this pull request Jul 19, 2019
@toblinkz
Copy link

toblinkz commented Jul 22, 2019 via email

@Guardiola31337
Copy link
Contributor Author

@toblinkz

Please can u tag the yoruba translation in the PR that updates them so they
will be available in the next release.

Not sure what you mean by ☝️

Are you referring to Project-OSRM/osrm-text-instructions#284

All translations added in OP will be available in the next release. Translations added in ☝️ will be available as soon as that PR gets merged, as my colleague @1ec5 described in #2000 (comment)

Once that PR is merged, we can do a release and deployment with the new translations. (The translations are deployed on the server side, so you won’t need to wait for a new navigation SDK release.)

@toblinkz
Copy link

toblinkz commented Jul 22, 2019 via email

@Guardiola31337
Copy link
Contributor Author

@toblinkz

Sorry what's the PR and how do I access it

I believe you're referring to Project-OSRM/osrm-text-instructions#284 If so, you can comment freely in there. Actually, there are a couple of comments / questions that would be 💯 if you can answer back 🙏 Project-OSRM/osrm-text-instructions#284 (review) Project-OSRM/osrm-text-instructions#284 (comment)

@toblinkz
Copy link

toblinkz commented Jul 22, 2019 via email

@toblinkz
Copy link

toblinkz commented Sep 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapbox localization
4 participants