-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yoruba localization #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of messages that seem to lack spaces around tokens. I’m not sure if that’s correct or not, but if it’s incorrect, then it’ll affect any Yoruba text-to-speech engine.
Good afternoon, please how can I can a make a third Party TTS engine in my
application that would be responsible for yoruba pronounciation?
…On Fri, Jul 19, 2019 at 6:25 PM Minh Nguyễn ***@***.***> wrote:
***@***.**** commented on this pull request.
There are a number of messages that seem to lack spaces around tokens,
which would be problematic for any text-to-speech engine.
------------------------------
In test/fixtures/v5/continue/left_destination.json
<#284 (comment)>
:
> @@ -37,6 +37,7 @@
"tr": "Destination 1 istikametinde sol yöne dön",
"uk": "Поверніть ліворуч у напрямку Destination 1",
"vi": "Quẹo trái về Destination 1",
+ "yo": "Tan-anapa osisi ọnaDestination 1",
Should the destination name be tacked onto the end of “ọna” like this, or
should there be a space in between?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#284?email_source=notifications&email_token=AD5JSRN43XNL4DNV7XEJLG3QAH2HFA5CNFSM4IFI4QY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7AXJCA#pullrequestreview-264336520>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD5JSRPAZNVZ7ZPNQF67GYDQAH2HFANCNFSM4IFI4QYQ>
.
|
I assume you’re referring to using a third-party TTS engine with the Mapbox Navigation SDK, per mapbox/mapbox-navigation-android#2000 (comment). Here’s a contrived example for iOS. The key is to subclass MapboxVoiceController and override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review merely a validation of the syntax and format. LGTM 👍
Thanks to @toblinkz for contributing a complete Yoruba localization in Transifex!
@toblinkz, can you double-check that the generated sentences make sense? Thanks!
/ref mapbox/mapbox-navigation-android#2000
/cc @danpaz @Guardiola31337