Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yoruba localization #284

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Add Yoruba localization #284

merged 2 commits into from
Jul 25, 2019

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jul 19, 2019

Thanks to @toblinkz for contributing a complete Yoruba localization in Transifex!

@toblinkz, can you double-check that the generated sentences make sense? Thanks!

/ref mapbox/mapbox-navigation-android#2000
/cc @danpaz @Guardiola31337

@1ec5 1ec5 requested a review from danpaz July 19, 2019 17:22
@1ec5 1ec5 self-assigned this Jul 19, 2019
Copy link
Member Author

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of messages that seem to lack spaces around tokens. I’m not sure if that’s correct or not, but if it’s incorrect, then it’ll affect any Yoruba text-to-speech engine.

test/fixtures/v5/continue/left_destination.json Outdated Show resolved Hide resolved
@toblinkz
Copy link

toblinkz commented Jul 22, 2019 via email

@1ec5
Copy link
Member Author

1ec5 commented Jul 23, 2019

Good afternoon, please how can I can a make a third Party TTS engine in my application that would be responsible for yoruba pronounciation?

I assume you’re referring to using a third-party TTS engine with the Mapbox Navigation SDK, per mapbox/mapbox-navigation-android#2000 (comment). Here’s a contrived example for iOS. The key is to subclass MapboxVoiceController and override speak(_:) to invoke the third-party TTS engine. If you need a corresponding hook for Android, I’d suggest following up in the mapbox-navigation-android repository.

Copy link
Contributor

@yuryleb yuryleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit looks good 👍

@1ec5 1ec5 requested a review from frederoni July 24, 2019 02:13
Copy link
Contributor

@frederoni frederoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review merely a validation of the syntax and format. LGTM 👍

@1ec5 1ec5 merged commit 6c93dba into master Jul 25, 2019
@1ec5 1ec5 deleted the 1ec5-tx-yo branch July 25, 2019 17:59
danpaz added a commit that referenced this pull request Sep 16, 2019
- Added a Yoruba localization. [#284](#284)
- Renamed “traffic circle” to “roundabout” in the English localization. [#285](#285)
- Rewrote the Burmese localization. [#282](#282)
- Fixed typographical errors in Italian. [#281](#281)
- Fixed grammatical errors in Danish. [#286](#286)
@danpaz danpaz mentioned this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants