Fix IllegalArgumentException when updating InstructionList

[danesfeder]

Found 🐛 in CI - regression from #1064

FATAL EXCEPTION: ControllerMessenger
Process: com.mapbox.services.android.navigation.testapp, PID: 26365
java.lang.IllegalArgumentException
	at java.util.AbstractList.subList(AbstractList.java:736)
	at com.mapbox.services.android.navigation.ui.v5.summary.list.InstructionListPresenter.removeInstructionsFrom(InstructionListPresenter.java:154)
	at com.mapbox.services.android.navigation.ui.v5.summary.list.InstructionListPresenter.updateInstructionList(InstructionListPresenter.java:146)
	at com.mapbox.services.android.navigation.ui.v5.summary.list.InstructionListPresenter.updateBannerListWith(InstructionListPresenter.java:53)
	at com.mapbox.services.android.navigation.ui.v5.summary.list.InstructionListAdapter.updateBannerListWith(InstructionListAdapter.java:49)
	at com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView.updateInstructionList(InstructionView.java:918)
	at com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView.updateDataFromInstruction(InstructionView.java:841)
	at com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView.access$000(InstructionView.java:79)
	at com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView$1.onChanged(InstructionView.java:190)
	at com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView$1.onChanged(InstructionView.java:186)
	at android.arch.lifecycle.LiveData.considerNotify(LiveData.java:109)
	at android.arch.lifecycle.LiveData.dispatchingValue(LiveData.java:126)
	at android.arch.lifecycle.LiveData.setValue(LiveData.java:282)
	at android.arch.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
	at com.mapbox.services.android.navigation.ui.v5.NavigationViewModel$1.onProgressChange(NavigationViewModel.java:262)
	at com.mapbox.services.android.navigation.v5.navigation.NavigationEventDispatcher.onProgressChange(NavigationEventDispatcher.java:144)
	at com.mapbox.services.android.navigation.v5.navigation.RouteProcessorThreadListener.onNewRouteProgress(RouteProcessorThreadListener.java:34)
	at com.mapbox.services.android.navigation.v5.navigation.RouteProcessorHandlerCallback$1.run(RouteProcessorHandlerCallback.java:97)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at androidx.test.espresso.base.Interrogator.a(Interrogator.java:19)
	at androidx.test.espresso.base.UiControllerImpl.a(UiControllerImpl.java:142)
	at androidx.test.espresso.base.UiControllerImpl.a(UiControllerImpl.java:134)
	at androidx.test.espresso.base.UiControllerImpl.a(UiControllerImpl.java:34)
	at androidx.test.espresso.action.MotionEvents.a(MotionEvents.java:74)
	at androidx.test.espresso.action.MotionEvents.a(MotionEvents.java:52)
	at androidx.test.espresso.action.Tap.c(Tap.java:9)
	at androidx.test.espresso.action.Tap.a(Tap.java:19)
	at androidx.test.espresso.action.Tap$1.b(Tap.java:2)
	at androidx.test.espresso.action.GeneralClickAction.perform(GeneralClickAction.java:22)
	at androidx.test.espresso.ViewInteraction$SingleExecutionViewAction.perform(ViewInteraction.java:9)
	at androidx.test.espresso.ViewInteraction.a(ViewInteraction.java:78)
	at androidx.test.espresso.ViewInteraction.a(ViewInteraction.java:94)
	at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:3)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5254)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

[Guardiola31337]

Is there a test covering this? If not, it'd be 💯 to add.

[Guardiola31337]

Thanks for adding a test checking the fixed issue ❤️

🚢 @danesfeder

[Guardiola31337]

CI is still reporting IllegalArgumentException

From AbstractList#subList docs 👀

IllegalArgumentException - if the endpoint indices are out of order (fromIndex > toIndex)