Fix IllegalArgumentException when updating InstructionList

mapbox · Jul 19, 2018 · 99226ac · 99226ac
1 parent 73b16a9
commit 99226ac
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/...a/com/mapbox/services/android/navigation/ui/v5/summary/list/InstructionListPresenter.java b/...a/com/mapbox/services/android/navigation/ui/v5/summary/list/InstructionListPresenter.java
@@ -122,7 +122,7 @@ private boolean addBannerInstructions(RouteProgress routeProgress) {
       List<LegStep> steps = currentLeg.steps();
       for (LegStep step : steps) {
         List<BannerInstructions> bannerInstructions = step.bannerInstructions();
-        if (bannerInstructions != null) {
+        if (bannerInstructions != null && !bannerInstructions.isEmpty()) {
           instructions.addAll(bannerInstructions);
           didAddInstructions = true;
         }
@@ -136,6 +136,9 @@ private boolean isNewLeg(RouteProgress routeProgress) {
   }
 
   private boolean updateInstructionList(RouteProgress routeProgress) {
+    if (instructions.isEmpty()) {
+      return false;
+    }
     RouteLegProgress legProgress = routeProgress.currentLegProgress();
     LegStep currentStep = legProgress.currentStep();
     double stepDistanceRemaining = legProgress.currentStepProgress().distanceRemaining();
@@ -150,8 +153,8 @@ private boolean removeInstructionsFrom(int currentInstructionIndex) {
     if (currentInstructionIndex == FIRST_INSTRUCTION_INDEX) {
       instructions.remove(FIRST_INSTRUCTION_INDEX);
       return true;
-    } else if (currentInstructionIndex < instructions.size() - 1) {
-      instructions.subList(0, currentInstructionIndex).clear();
+    } else if (currentInstructionIndex <= instructions.size()) {
+      instructions.subList(FIRST_INSTRUCTION_INDEX, currentInstructionIndex).clear();
       return true;
     }
     return false;

diff --git a/...m/mapbox/services/android/navigation/ui/v5/summary/list/InstructionListPresenterTest.java b/...m/mapbox/services/android/navigation/ui/v5/summary/list/InstructionListPresenterTest.java
@@ -18,6 +18,7 @@
 import java.util.List;
 
 import static junit.framework.Assert.assertEquals;
+import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyDouble;
@@ -107,6 +108,19 @@ public void updateBannerListWith_instructionListIsPopulated() throws Exception {
     assertTrue(didUpdate);
   }
 
+  @Test
+  public void updateBannerListWith_emptyInstructionsReturnFalse() throws Exception {
+    RouteProgress routeProgress = buildRouteProgress();
+    RouteUtils routeUtils = buildRouteUtils(routeProgress);
+    clearInstructions(routeProgress);
+    DistanceFormatter distanceFormatter = mock(DistanceFormatter.class);
+    InstructionListPresenter presenter = new InstructionListPresenter(routeUtils, distanceFormatter);
+
+    boolean didUpdate = presenter.updateBannerListWith(routeProgress);
+
+    assertFalse(didUpdate);
+  }
+
   @NonNull
   private RouteProgress buildRouteProgress() throws Exception {
     DirectionsRoute route = buildTestDirectionsRoute();
@@ -140,4 +154,13 @@ private int retrieveInstructionSizeFrom(RouteLeg routeLeg) {
     }
     return instructions.size() - 1;
   }
+
+  private void clearInstructions(RouteProgress routeProgress) {
+    for (LegStep step : routeProgress.currentLeg().steps()) {
+      List<BannerInstructions> instructions = step.bannerInstructions();
+      if (instructions != null) {
+        instructions.clear();
+      }
+    }
+  }
 }