Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metric arrival event reset for multiple waypoints #1022

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

danesfeder
Copy link
Contributor

Closes #1012

The off route listener was not being removed upon arrival because the metricArrivalListener was null. This was a regression from #943. Now that we use milestones, the milestone listener will only fire once and we don't need to worry about resetting a listener / duplicate events as a result.

Using the three waypoints from the ticket:
ezgif com-video-to-gif

@danesfeder danesfeder self-assigned this Jun 12, 2018
@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels Jun 12, 2018
@danesfeder danesfeder added this to the 0.15.0 milestone Jun 12, 2018
@danesfeder danesfeder force-pushed the dan-remove-reset-arrival branch 2 times, most recently from 9c02f3c to 55478a4 Compare June 15, 2018 17:04
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@Guardiola31337
Copy link
Contributor

Looking good 🚀

But Firebase doesn't think so 😂

FATAL EXCEPTION: main
Process: com.mapbox.services.android.navigation.testapp, PID: 17527
java.lang.NullPointerException: Attempt to invoke interface method 'void com.mapbox.services.android.navigation.v5.navigation.metrics.NavigationMetricListener.onArrival(com.mapbox.services.android.navigation.v5.routeprogress.RouteProgress)' on a null object reference
	at com.mapbox.services.android.navigation.v5.navigation.NavigationEventDispatcher.checkForArrivalEvent(NavigationEventDispatcher.java:175)
	at com.mapbox.services.android.navigation.v5.navigation.NavigationEventDispatcher.onMilestoneEvent(NavigationEventDispatcher.java:135)
	at com.mapbox.services.android.navigation.v5.navigation.NavigationService.onMilestoneTrigger(NavigationService.java:125)
	at com.mapbox.services.android.navigation.v5.navigation.NavigationEngine$1.run(NavigationEngine.java:93)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5254)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

@danesfeder danesfeder force-pushed the dan-remove-reset-arrival branch from 55478a4 to e02ecb4 Compare June 15, 2018 19:43
@danesfeder danesfeder force-pushed the dan-remove-reset-arrival branch from e02ecb4 to 1ff67f7 Compare June 15, 2018 19:44
@danesfeder danesfeder merged commit 7cab174 into master Jun 15, 2018
@danesfeder danesfeder deleted the dan-remove-reset-arrival branch June 15, 2018 20:31
@danesfeder danesfeder mentioned this pull request Jun 21, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants