Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nullReferenceException in checkForArrivalEvent #1086

Closed
richjhart opened this issue Jul 5, 2018 · 2 comments
Closed

New nullReferenceException in checkForArrivalEvent #1086

richjhart opened this issue Jul 5, 2018 · 2 comments
Labels
bug Defect to be fixed.
Milestone

Comments

@richjhart
Copy link

**Android API:**N/A
Mapbox Navigation SDK version: 0.15.0

Fatal Exception: java.lang.NullPointerException
Attempt to invoke interface method 'void com.mapbox.services.android.navigation.v5.navigation.b.c.b(com.mapbox.services.android.navigation.v5.f.i)' on a null object reference
com.mapbox.services.android.navigation.v5.navigation.NavigationEventDispatcher.checkForArrivalEvent (NavigationEventDispatcher.java:177)
com.mapbox.services.android.navigation.v5.navigation.NavigationEventDispatcher.onMilestoneEvent (NavigationEventDispatcher.java:135)
com.mapbox.services.android.navigation.v5.navigation.NavigationService.onMilestoneTrigger (NavigationService.java:125)
com.mapbox.services.android.navigation.v5.navigation.NavigationEngine$1.run (NavigationEngine.java:93)

#1022 added a number of null checks for metricEventListener, but removed the null check from checkForArrivalEvent(). I guess there's an assumption that "isArrivalEvent" should only be true once - apparently that's not always true.

@danesfeder
Copy link
Contributor

Hey @richjhart, another good catch here - being working in #1070. Will close when the PR lands - thank you for reporting!

@richjhart
Copy link
Author

Ah yeah, I had a look for a previous report but missed #1070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants