Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add via waypoints support to MapboxDirections #959

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Add via waypoints support to MapboxDirections #959

merged 1 commit into from
Feb 8, 2019

Conversation

Guardiola31337
Copy link
Contributor

Fixes #956

  • Adds via waypoints support to MapboxDirections

@Guardiola31337 Guardiola31337 self-assigned this Feb 8, 2019
@Guardiola31337 Guardiola31337 force-pushed the pg-956-via-waypoints branch 5 times, most recently from db62802 to 449941b Compare February 8, 2019 19:21
@osana
Copy link
Contributor

osana commented Feb 8, 2019

@Guardiola31337 Two questions:

  • could you add a test to make sure that waypoints are being added to the request string
  • CI changes ? I am guessing that will be changed.

@Guardiola31337
Copy link
Contributor Author

@osana

  • could you add a test to make sure that waypoints are being added to the request string

Of course! This is updated and ready for another round of 👀

  • CI changes ? I am guessing that will be changed.

Yeah, I've released momentarily a SNAPSHOT to test OP's changes in the Navigation side. It's already reverted.

@Guardiola31337 Guardiola31337 merged commit f99a072 into master Feb 8, 2019
@Guardiola31337 Guardiola31337 deleted the pg-956-via-waypoints branch February 8, 2019 22:37
@Guardiola31337 Guardiola31337 mentioned this pull request Feb 11, 2019
Merged
@osana osana mentioned this pull request Feb 12, 2019
Closed
14 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Mar 1, 2019
Closed
@Guardiola31337 Guardiola31337 mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osana osana osana approved these changes

@danesfeder danesfeder Awaiting requested review from danesfeder

Assignees

@Guardiola31337 Guardiola31337

Labels
Directions Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guardiola31337 @osana