Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waypoint indices option for Directions API #956

Closed
danesfeder opened this issue Jan 30, 2019 · 2 comments
Closed

Add waypoint indices option for Directions API #956

danesfeder opened this issue Jan 30, 2019 · 2 comments
Assignees

Comments

@danesfeder
Copy link
Contributor

The Directions API will soon expose a waypoints parameter similar to the Map Matching API’s: Project-OSRM/osrm-backend#5345.

We should add / account for this parameter - iOS equivalent in mapbox/mapbox-directions-swift#334

@1ec5
Copy link
Contributor

1ec5 commented Jan 30, 2019

This SDK exposes the waypoints parameter as a simple array of integers, so the same code could probably be copied to RouteOptions.

mapbox/mapbox-directions-swift#334 discusses some refactoring we’d like to do on the Swift side to make the option more object-oriented, but the approach in Java might differ since this SDK follows the Builder pattern.

@osana
Copy link
Contributor

osana commented Feb 8, 2019

@1ec5 good point about RouteOptions. Thank you for bringing it up.

I think you are absolutely right those should be added to the RouteOptions.
In fact they should be added to RouteOptions in MapMatching as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants