added toJson and fromJson to Directions models #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-toFromJson
branch
5 times, most recently
from
e396a9f to
0c63379
Compare
danesfeder
reviewed
Jul 23, 2018
There was a problem hiding this comment.
Just a minor typo and question about pending TODO - everything else looks 💯 thanks for running with this @osana 🚀
| * This takes the currently defined values found inside this instance and converts it to a json | ||
| * string. | ||
| * | ||
| * @return a JSON string which represents this IntersectionLanes |
There was a problem hiding this comment.
Javadoc typo IntersectionLanes
| .instruction("Turn left onto Adalbertstraße") | ||
| .build()) | ||
| .intersections(intersections) | ||
| // TODO: Include the following |
There was a problem hiding this comment.
Does this TODO need to be addressed before merging?
There was a problem hiding this comment.
@danesfeder Thanks for flagging the TODOs.
I am not sure what kind of request would have those fields filled. Could you help me with those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #854 , #696