Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fromJson method to DirectionsRoute #696

Merged
merged 2 commits into from
Jan 19, 2018
Merged

Add fromJson method to DirectionsRoute #696

merged 2 commits into from
Jan 19, 2018

Conversation

danesfeder
Copy link
Contributor

For converting a JSON String representing a DirectionsRoute to an actual DirectionsRoute object

@danesfeder danesfeder self-assigned this Jan 16, 2018
@danesfeder danesfeder requested a review from cammace January 16, 2018 22:03
@cammace
Copy link
Contributor

cammace commented Jan 17, 2018

While this works, let's wait and see what #695 pans out to be, probably won't need to register as many typeAdapters.

@cammace cammace merged commit e1599e9 into master Jan 19, 2018
@cammace cammace deleted the dan-fromjson-directionsroute branch January 19, 2018 18:57
@osana osana mentioned this pull request Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

Assignees

@danesfeder danesfeder

Labels
Directions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @cammace