This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Limit annotation view pan gesture check to own recognizer #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows non-dragging pans that are initiated on views to pan the underlying map. Annotation views each have long press and pan gesture recognizers. If a view is not draggable or not in a positive dragging state, the pan gesture recognizer should not begin. This commit makes the criteria for rejecting pans more strict — only `_panGestureRecognizer` should be rejected, not the entire `UIPanGestureRecognizer` class.
friedbunny
added
bug
iOS
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @bleege, @1ec5 and @boundsj to be potential reviewers. |
|
I did not know that coveralls could fail:
... |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5539. Allows non-dragging pan gestures that are initiated on view annotations to pan the underlying map.
(This PR is now filed against the v3.3.0 release branch and supersedes #5812.)
Annotation views each have long press and pan gesture recognizers. If a view is not draggable or not in a positive dragging state, the pan gesture recognizer should not begin. This commit makes the criteria for rejecting pans more strict — only
_panGestureRecognizershould be rejected, not the entireUIPanGestureRecognizerclass./cc @frederoni @1ec5