Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix crash drawing compass on iOS 7 #5791

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 25, 2016

Fixes #5780.

/cc @friedbunny

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS crash labels Jul 25, 2016
@1ec5 1ec5 added this to the ios-v3.3.2 milestone Jul 25, 2016
@1ec5 1ec5 self-assigned this Jul 25, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 25, 2016

The “N” ends up being quite faint in iOS 8.1:

8.1

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 26, 2016

@incanus, can you try out this fix on an iOS 7 device, just in case?

@1ec5 1ec5 changed the title Fix crash drawing compass on iOS 8.1 Fix crash drawing compass on iOS 7 Jul 26, 2016
@1ec5 1ec5 merged commit 850b2e2 into release-ios-v3.3.0 Jul 27, 2016
@1ec5 1ec5 deleted the 1ec5-compass-font-5780 branch July 27, 2016 05:45
@friedbunny
Copy link
Contributor

It is quite difficult to validate this fix: no one at Mapbox has access to an iOS 7 device and the iOS 7 simulator no longer runs on the current version of macOS. This fix is therefore speculative — we’re confident, but cannot be absolutely sure that it solves the issue.

1ec5 added a commit that referenced this pull request Jul 28, 2016
#5791 affects iOS 7.x, not 8.1 or 8.2. Describe #5813 in simpler terms.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crash iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants