This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] trigger repaint after placement is redone #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes look good. One render test failed: symbol-avoid-edges rotated-false.
It looks like other |
ansis
force-pushed
the
placement-redone-update
branch
from
44b75ee to
0abef62
Compare
fixes #3140 This also fixes a bug where placement could be redone with a stale PlacementConfig after the tile first finishes loading.
ansis
force-pushed
the
placement-redone-update
branch
from
0abef62 to
0101fc0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
onPlacementRedonetoSource::Observerwhich is called when a tile is updated with new symbol placement. Style uses this to trigger a repaint.fixes #3140
This also fixes a bug where placement could be redone with a stale PlacementConfig after the tile first finishes loading.
@jfirebaugh can you review?