Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Collision debug does not properly repaint upon toggling #3140

Closed
brunoabinader opened this issue Nov 27, 2015 · 1 comment · Fixed by #3657
Closed

Collision debug does not properly repaint upon toggling #3140

brunoabinader opened this issue Nov 27, 2015 · 1 comment · Fixed by #3657
Assignees
Labels

Comments

@brunoabinader
Copy link
Member

Collision debug toggling should trigger a repaint once the symbol buckets have been updated. This doesn't seem to be the case as the collision boxes are only visible e.g. when enabling collision debug after a second call to MapContext::update().

Current behavior feels correct because usually we are causing more repaints due to e.g. mouse gestures. In GLFW example, if we keep pressing C key the behavior also feels correct because each time we press the shortcut, the previous repaint gives the wrong impression that collision debug state is the same as visible on-screen.

/cc @mapbox/gl

@incanus incanus added the bug label Nov 30, 2015
@ansis ansis self-assigned this Jan 21, 2016
ansis added a commit that referenced this issue Jan 22, 2016
fixes #3140

This also fixes a bug where placement could be redone with a stale
PlacementConfig after the tile first finishes loading.
@ansis ansis removed the in progress label Jan 22, 2016
@kkaefer
Copy link
Member

kkaefer commented Jan 25, 2016

\o/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants