This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] fix mixed sdf + non-sdf icon rendering in one layer #15456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
reviewed
Aug 23, 2019
pozdnyakov
reviewed
Aug 26, 2019
pozdnyakov
approved these changes
Aug 26, 2019
alexshalamov
approved these changes
Aug 26, 2019
chloekraw
added
🍒 cherry pick
|
thanks for this @zmiao! I'd like this cherrypicked into the |
chloekraw
added
the
needs changelog
|
@zmiao also, would you mind drafting a changelog entry and/or providing a quick summary of the issue's root cause that we can use for the changelog? Thanks! |
|
@chloekraw Thanks for the reminder, I opened a new pr for it, I will do the cherrypick afterwards. |
zmiao
added a commit
that referenced
this pull request
Aug 27, 2019
* [core] fix icon symbol rendring when sdf and non-sdf icon in the same symbol layer * fix build error * fix typo * revert renderableSegment change * simplify codes * fix build error * refine sdf icon flag * [core] fix mixed sdf + non-sdf icon rendering in one layer * remove iconstatus getter in stymbol bucket * fix review findings * provide bitwise operator for SymbolContent enum * use MBGL_MBGL_CONSTEXPR * add one missing update for sdfIcon * make renderer symbol type as enum
zmiao
added a commit
that referenced
this pull request
Aug 27, 2019
…ne layer (#15494) * [core] fix mixed sdf + non-sdf icon rendering in one layer (#15456) * [core] fix icon symbol rendring when sdf and non-sdf icon in the same symbol layer * fix build error * fix typo * revert renderableSegment change * simplify codes * fix build error * refine sdf icon flag * [core] fix mixed sdf + non-sdf icon rendering in one layer * remove iconstatus getter in stymbol bucket * fix review findings * provide bitwise operator for SymbolContent enum * use MBGL_MBGL_CONSTEXPR * add one missing update for sdfIcon * make renderer symbol type as enum * Add changelog for fix of mixed SDF+non-SDF icon rendering in one layer (#15492) * Add changelog for fix of mixed SDF+non-SDF icon rendering in one layer * Add bracket for ios changelog number * Add more brackets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #14809
Render test: mapbox/mapbox-gl-js#8674