Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Optimize Query Rendered Features API #15209

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

pozdnyakov
Copy link
Contributor

This PR filters out invisible layers before quering features
(rather than after, like it happened before).

With this change API_queryRenderedFeaturesAll performance test
passes almost two times faster.

Fixes: #15207

@friedbunny friedbunny added Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage labels Jul 24, 2019
@friedbunny friedbunny added this to the release-queso milestone Jul 24, 2019
This PR filters out invisible layers before quering features
(rather than after, like it happened before).

With this change `API_queryRenderedFeaturesAll` performance test
passes almost two times faster.
@pozdnyakov pozdnyakov force-pushed the mikhail_optimize_qrf_api branch from db9f5f0 to 3007acf Compare July 25, 2019 08:20
@pozdnyakov pozdnyakov merged commit 0051fcd into master Jul 25, 2019
@pozdnyakov pozdnyakov deleted the mikhail_optimize_qrf_api branch July 25, 2019 09:58
@chloekraw chloekraw added the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl needs changelog Indicates PR needs a changelog entry prior to merging. performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Performance regression on queryRenderedFeatures
6 participants