Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Performance regression on queryRenderedFeatures #15207

Closed
tmpsantos opened this issue Jul 24, 2019 · 1 comment · Fixed by #15209
Closed

[core] Performance regression on queryRenderedFeatures #15207

tmpsantos opened this issue Jul 24, 2019 · 1 comment · Fixed by #15209
Assignees
@pozdnyakov
Labels
Core The cross-platform C++ core, aka mbgl regression
Milestone
release-queso

Comments

@tmpsantos
Copy link
Contributor

tmpsantos commented Jul 24, 2019 •
edited
Loading

Introduced by #15092

Before:

--------------------------------------------------------------------
Benchmark                             Time           CPU Iterations
--------------------------------------------------------------------
API_queryRenderedFeaturesAll  171241869 ns  171044029 ns          4

After:

$ BUILDTYPE=Release make run-benchmark-API_queryRenderedFeaturesAll -j8
--------------------------------------------------------------------
Benchmark                             Time           CPU Iterations
--------------------------------------------------------------------
API_queryRenderedFeaturesAll  326807604 ns  326616105 ns          2

/cc @pozdnyakov
@tmpsantos tmpsantos added Core The cross-platform C++ core, aka mbgl regression labels Jul 24, 2019
@pozdnyakov
Copy link
Contributor

8faf47a had introduced performance benefit for QRF API. In #15092 it was partially reverted.

@pozdnyakov pozdnyakov self-assigned this Jul 24, 2019
@pozdnyakov pozdnyakov mentioned this issue Jul 24, 2019
Merged
@friedbunny friedbunny added this to the release-queso milestone Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pozdnyakov pozdnyakov

Labels
Core The cross-platform C++ core, aka mbgl regression
Projects
None yet
Milestone
release-queso
Development

Successfully merging a pull request may close this issue.

[core] Optimize Query Rendered Features API mapbox/mapbox-gl-native
3 participants
@tmpsantos @pozdnyakov @friedbunny