This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Change "map ID" to "tileset ID" #15116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbarbosa
approved these changes
Jul 15, 2019
| point to a JSON file that conforms to the | ||
| <a href="https://github.com/mapbox/tilejson-spec/">TileJSON specification</a>. | ||
|
|
||
| If a Mapbox URL is specified, this source uses a tile size of 256. For all | ||
| other tile sets, the default value is 512. (See the | ||
| other tilesets, the default value is 512. (See the |
|
@captainbarbosa Great idea! Changelog entries added. Also, ummm... I can't figure out why the CircleCI tests are failing 🙈 Any ideas? |
friedbunny
added
documentation
iOS
|
CI failures look like unrelated flakiness — I’ll rerun those jobs. |
friedbunny
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: We're changing instances of
map IDto be the more accurate termtileset IDacross all Mapbox documentation. @1ec5 also found a number of instances where the docs in this repo refer toa style's map ID, which is more accurately a style URL.Per #14551, this PR:
map IDtotileset IDwhere necessarystyle's map IDtostyle URLwhere necessary@captainbarbosa or @1ec5 to review, please! 🙏