Rename map identifiers to tileset identifiers

[1ec5]

Map IDs are being renamed to tileset IDs across the board. We refer to map IDs in a couple places in the iOS/macOS map SDK’s header documentation:

mapbox-gl-native/platform/darwin/src/MGLRasterTileSource.h

Line 74 in 9bd59bf

Mapbox URL indicating a map identifier (`mapbox://<mapid>`). The URL should

mapbox-gl-native/platform/darwin/src/MGLRasterTileSource.h

Line 100 in 9bd59bf

Mapbox URL indicating a map identifier (`mapbox://<mapid>`). The URL should

There are also several occurrences of “a Mapbox URL indicating the style’s map ID”, which is inaccurate following #1561. These occurrences should be replaced by “a Mapbox URL identifying the style”:

mapbox-gl-native/platform/darwin/src/MGLOfflineRegion.h

Line 18 in d3bb518

map ID (`mapbox://styles/{user}/{style}`).

mapbox-gl-native/platform/macos/src/MGLMapView+IBAdditions.h

Line 25 in f3341dd

map ID (`mapbox://styles/<user>/<style>`), or a path to a local file

mapbox-gl-native/platform/darwin/src/MGLShapeOfflineRegion.h

Lines 62 to 63 in 5d891b4

	may be a full HTTP or HTTPS URL or a Mapbox URL indicating the style’s map
	ID (`mapbox://styles/{user}/{style}`). Specify `nil` for the default style.

mapbox-gl-native/platform/darwin/src/MGLTilePyramidOfflineRegion.h

Lines 64 to 65 in 5d891b4

	may be a full HTTP or HTTPS URL or a Mapbox URL indicating the style’s map
	ID (`mapbox://styles/{user}/{style}`). Specify `nil` for the default style.

mapbox-gl-native/platform/darwin/src/MGLMapSnapshotter.h

Line 18 in 67e5761

HTTPS URL, a Mapbox URL indicating the style’s map ID

mapbox-gl-native/platform/macos/src/MGLMapView.h

Line 87 in 7017ac5

HTTPS URL, a Mapbox URL indicating the style’s map ID

mapbox-gl-native/platform/macos/src/MGLMapView.h

Line 134 in 7017ac5

map ID (`mapbox://styles/<user>/<style>`), or a path to a local file relative

mapbox-gl-native/platform/ios/src/MGLMapView.h

Line 202 in 9bd59bf

or HTTPS URL, a Mapbox URL indicating the style’s map ID

mapbox-gl-native/platform/ios/src/MGLMapView.h

Line 262 in 9bd59bf

map ID (`mapbox://styles/{user}/{style}`), or a path to a local file

/cc @mapbox/maps-ios @brsbl

[zugaldia]

/cc: @tobrun for Android.

[tobrun]

/cc: @tobrun for Android.

I believe nothing needs to be picked up from Android as we don't use the terms map ID

[HeyStenson]

@1ec5 In looking at this, it seems that in several cases we're using the term style's map ID to refer to a style url (rather than a map ID/tileset ID).

I believe that in your OP, that's the case in the following files:

• mapbox-gl-native/platform/darwin/src/MGLOfflineRegion.h
• mapbox-gl-native/platform/macos/src/MGLMapView+IBAdditions.h
• mapbox-gl-native/platform/darwin/src/MGLShapeOfflineRegion.h
• mapbox-gl-native/platform/darwin/src/MGLTilePyramidOfflineRegion.h
• mapbox-gl-native/platform/darwin/src/MGLMapSnapshotter.h
• mapbox-gl-native/platform/macos/src/MGLMapView.h
• mapbox-gl-native/platform/ios/src/MGLMapView.h

If that's correct, only the following need to have language changed from map ID to tileset ID:

• mapbox-gl-native/platform/darwin/src/MGLRasterTileSource.h
• mapbox-gl-native/platform/darwin/src/MGLVectorTileSource.h

and we should consider changing the rest of the instances you found to style URL instead. Does that sound right to you?

EDIT: Reading comprehension fail! Sorry, @1ec5, completely glossed over the fact that you already pointed out that we are referring incorrectly to map IDs in your original post 😬

[julianrex]

Sounds good to me.

[julianrex]

Fixed in #15116