-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ios , macos] Exclude CJK resources from offline download by default #14952
Conversation
cc: @chloekraw @julianrex |
Thanks for this PR, @m-stephen. Is this blocked by #14271? |
@chloekraw I don't think so, just on iOS side. I wrote a offline pack demo today and make a clean(no cache) app for testing:
And after download these offline resources, I switch to airplane mode and I think it rendered well: cc: @zugaldia |
Btw, this PR should be approved after #14862 merged because we have changed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@julianrex Sorry for forgetting upload test codes, already uploaded now. Please review it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits and changelog edits, but otherwise LGTM.
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
In #14952 (comment) you mentioned:
@m-stephen do you mean that your local font family for glyphs generation is set to |
Yes. For clarifying this case, the |
@m-stephen - we'd love to get this PR in before the cc @chriswu42 @mapbox/maps-ios |
Sorry for forgetting to merge this, already merged! @chloekraw |
No problem - thanks! |
Closes: #14176
After this PR: #14862 merged, we exclude CJK resources from offline download by default.