-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ios, macos] Default to local rendering of CJK characters, using system font #14862
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…t `MGLIdeographicFontFamilyName` to `NULL` for using your custom remote font.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FYI, I also found another issue, we cannot render the We use local font in: mapbox-gl-native/platform/darwin/src/local_glyph_rasterizer.mm Lines 98 to 100 in df062af
and in mapbox-gl-native/src/mbgl/util/i18n.cpp Lines 416 to 419 in d7fa18e
we judge characters whether can rasterize or not. The mapbox-gl-native/src/mbgl/util/i18n.cpp Line 141 in d7fa18e
The unicodes range is from I’ll make a new commit to fix this issue and need GL team help to review. |
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
Co-Authored-By: Jason Wray <[email protected]>
@friedbunny I have added some plist value tests, please re-review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience throughout the process, @m-stephen. 🙇
Kanji
characters as default local rendering strategy
Closes: #14470
Closes: #14866
Fixed an issue that caused the map to ignore the remote fonts for CJK Kanji glyphs.
Added ability to specify an array of fonts for fallbacks for local ideographic font family.
After this PR merged, we will:
MGLIdeographicFontFamilyName
to a string value, which is a custom local font family name, e.g.PingFang TC
, we will use that for local rendering.MGLIdeographicFontFamilyName
to an array of local fonts' family name, we will choose the first available font of that array. If there isn't an available font name, fallback to system default font.For example, we will use
PingFang TC
as a local font:MGLIdeographicFontFamilyName
to a boolean value ofNO
, we will use their remote CJK font.