This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add Logging level tests (and vararg version of logCallingFunction) #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
approved these changes
Aug 14, 2020
| MGLLogDebug(format); | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-implementations" | ||
| // TODO: Remove in future release. |
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
To bypass a catch-22; I marked the protocol methods as deprecated, and so the compiler warns (errors) if you add them. But if they're missing then the compiler errors about an incomplete conformance. 🤕
| - (void)testLoggingLevelInfo { | ||
| [self internalTestLoggingLevel:MGLLoggingLevelInfo | ||
| expectingLogForLevels:@[ | ||
| // @(MGLLoggingLevelDebug), |
There was a problem hiding this comment.
nit: please remove commented code.
There was a problem hiding this comment.
Tempted to leave for the moment, as in this case it's kinda documentation when seen alongside the other tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests as a part of: #370
See gl-native for the associated fix for #370 (which uses
Log::Observerinstead of calling down to-[MGLNetworkConfiguration debugLog:]etc).Fixes #347 (along with next gl-native release)
Fixes mapbox/mapbox-gl-native#16511