Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Crash in logging (Debug and Error levels) #370

Closed
julianrex opened this issue Aug 7, 2020 · 0 comments
Closed

Crash in logging (Debug and Error levels) #370

julianrex opened this issue Aug 7, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@julianrex
Copy link
Contributor

Variable arguments are not being passed to debugLog and errorLog here:

- (void)debugLog:(NSString *)format, ... {
MGLLogDebug(format);
}
- (void)errorLog:(NSString *)format, ... {
MGLLogError(format);
}

This will result in a crash if the logging level is set to include debug or errors.

We need to add a method to MGLLoggingConfiguration, along the lines of:

- (void)logCallingFunction:(const char *)callingFunction functionLine:(NSUInteger)functionLine messageType:(MGLLoggingLevel)type format:(id)messageFormat arguments:(va_list)argList;

(and associated calling macros).

Configuration

Mapbox SDK versions: 6.1.0-beta.1 (though was introduced in #228)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants