fix dashed lines with square line caps #9561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9531
This adds square caps to each dash (matching what svg does). It does this by making every pixel within the sdf 0.5 line widths closer to the edge of the dashed line. It also makes the square cap of the line it's own quad to avoid stretching the distance-along-the line which would make coincident dashed lines not line up properly.
Before:
After:
Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Fix dashed lines with square line caps.</changelog>
@mapbox/map-design-team this PR includes visual changes for dashed lines with square line caps. Do you think any styles need to be adjusted or would this combination be uncommon enough to not affect much? @mapbox/static-apis I'm not sure whether these visual changes would affect you in any way.
@tmpsantos this needs a -native port