Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line-dasharray with square line cap not rendering correctly #9531

Closed
tmpsantos opened this issue Apr 9, 2020 · 0 comments · Fixed by #9561
Closed

line-dasharray with square line cap not rendering correctly #9531

tmpsantos opened this issue Apr 9, 2020 · 0 comments · Fixed by #9561
Assignees
@mourner @ansis
Labels
bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@tmpsantos
Copy link
Contributor

It is rendering is an offset. When placing two lines overlapping to create an outline effect, it is more evident.

expected1

When using round line cap, it renders as expected.

expected2
@tmpsantos tmpsantos added bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) labels Apr 9, 2020
@tmpsantos tmpsantos mentioned this issue Apr 9, 2020
Merged
ansis added a commit that referenced this issue Apr 13, 2020
@ansis
fix "line-dasharray" with "line-cap": "square"
a48df69 
fix #9531
@ansis ansis mentioned this issue Apr 14, 2020
Merged
8 tasks
mourner pushed a commit that referenced this issue May 4, 2021
@ansis @mourner
fix "line-dasharray" with "line-cap": "square"
4f7eda4 
fix #9531
mourner pushed a commit that referenced this issue May 6, 2021
@ansis @mourner
fix "line-dasharray" with "line-cap": "square"
4533cc9 
fix #9531
mourner added a commit that referenced this issue May 6, 2021
@ansis @mourner
fix dashed lines with square line caps (#9561)
7ca8f72 
* fix "line-dasharray" with "line-cap": "square"

fix #9531

* remove leftover

Co-authored-by: Vladimir Agafonkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mourner mourner

@ansis ansis

Labels
bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix dashed lines with square line caps mapbox/mapbox-gl-js
3 participants
@mourner @tmpsantos @ansis