-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add originalEvent
property to NavigationControl events
#8693
Add originalEvent
property to NavigationControl events
#8693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepankuzmin Thanks for this fix. Looks good , but could you also add a note in the docs to signal that the MouseEvent
can be a click when the zoom is triggered by a UI event.
Lines 216 to 219 in 506a3ef
/** | |
* @typedef {Object} MapBoxZoomEvent | |
* @property {MouseEvent} originalEvent | |
*/ |
@asheemmamoowala I've added a note for this |
Also, could you please rebase on |
1a6e9ea
to
2772364
Compare
@mourner done! |
This PR adds
originalEvent
property to events initiated usingNavigationControl
(zoom in, zoom out, reset bearing). Relates to #6405