onViewportChange not triggered using NavigationControl

[charlietfl]

Describe the bug
Using default map zoom controls not triggering viewport change event in parent <MapGL>

To Reproduce
Steps to reproduce the behavior:

1. Go to docs example https://urbica.github.io/react-map-gl/#/Controls/NavigationControl
2. Edit code block adding onViewportChange={viewport=>console.log(JSON.stringify(viewport))} to <MapGL> component
3. Open console, drag map center...see new viewport config in console
4. Change zoom using +/- in NavControl ... no output

Expected behavior
Would expect event to be triggered using NavigationControl but instead it only seems to affect the map-gl instance

Desktop (please complete the following information):

• OS: Windows
• Browser: Chrome

[jperals]

I'd like to have this fixed too. @stepankuzmin Shall I submit a PR?

[stepankuzmin]

Hey @jperals! It would be really great! PRs are welcome!

[jperals]

It seems like the problem is that MapGL's _onViewportChange filters events that have an originalEvent property set, but it turns out that for certain interactions (among them, those coming from the NavigationControl) don't provide this property: mapbox/mapbox-gl-js#6405

I worked around this by just checking that the event exists (or that it's truthy, to be more exact) instead of its properties: jperals@f6fd40b

So this is the simplest solution I could come up with. Would it make more sense to check for some other properties in the object instead? This doesn't seem to have side effects for our use case and passes the tests (though I had to modify one of them as you can see), but of course I'm open to your feedback @stepankuzmin.

[stepankuzmin]

Thanks for the research, @jperals!

Unfortunately we can't remove check for originalEvent because it is the only way to detect user-initiated events. The most concise way to fix this issue, IMO, is to add originalEvent to events initiated using NavigationControl.

I've created PR for this in mapbox-gl-js repo mapbox/mapbox-gl-js#8693

[stepankuzmin]

This should be fixed in the nest version of mapbox-gl since PR is merged mapbox/mapbox-gl-js#8693

[derwaldgeist]

Just stumbled upon the same problem in the GeolocationControl (#276). Is there any update on when a new version will arrive that fixed this?