Fix usage of String#includes which is es6 but not transformed by buble #8565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Jul 29, 2019
src/util/mapbox.js
Outdated
| @@ -178,7 +178,7 @@ export class RequestManager { | |||
| if (accessToken[0] === 's') | |||
| throw new Error(`Use a public access token (pk.*) with Mapbox GL, not a secret access token (sk.*). ${help}`); | |||
|
|
|||
| urlObject.params = urlObject.params.filter((d) => !d.includes('access_token')); | |||
| urlObject.params = urlObject.params.filter((d) => d.indexOf('access_token') !== -1); | |||
There was a problem hiding this comment.
Invert the comparison — "not includes" will translate to indexOf(...) === -1.
There was a problem hiding this comment.
Thank you Vlad. Classic.
mourner
approved these changes
Jul 29, 2019
ahk
added a commit
that referenced
this pull request
Jul 29, 2019
peterqliu
pushed a commit
that referenced
this pull request
Jul 29, 2019
mourner
added a commit
that referenced
this pull request
Jul 30, 2019
* origin/publisher-production: update version to v1.2.0 (#8562) Fix usage of String.includes which is es6 but not transformed by buble (#8565) (#8573) [docs] fix missing location prop to feedback component (#8554) Fix typo [docs] update dr-ui (#8548) [docs] fix errors on IE11 caused by dr-ui dependencies (#8544) updates directions plugin version (#8536) add dds sdk support squash (#8529) [docs] adds feedback component (#8507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a usage of
String#includeswhich breaks in any non-es6 browser and is also not handled by buble transformation.