[docs] fix missing location prop for feedback #8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyStenson
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
@katydecorah Just checked on staging and this looks correct to me! For feedback on https://docs.tilestream.net/mapbox-gl-js/api/#lnglat#wrap, in Segment I see a page object that contains hash: '#lnglat' and pathname: '/mapbox-gl-js/api/', along with the property section: 'wrap'. Pretty sure those are all the right pieces! 🍊
mourner
added a commit
that referenced
this pull request
Jul 30, 2019
* origin/publisher-production: update version to v1.2.0 (#8562) Fix usage of String.includes which is es6 but not transformed by buble (#8565) (#8573) [docs] fix missing location prop to feedback component (#8554) Fix typo [docs] update dr-ui (#8548) [docs] fix errors on IE11 caused by dr-ui dependencies (#8544) updates directions plugin version (#8536) add dds sdk support squash (#8529) [docs] adds feedback component (#8507)
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
As the feedback data is starting to come in, we found that the feedback comonent inside the collapsible sections of the API docs (example: /mapbox-gl-js/api/#map#triggerrepaint) was not sending the current page along with the response. This PR makes sure the prop is passed through to the component so we have data on which page the user submitted feedback.
npm run buildto catch any build errors or force push topublisher-staging.pageobject withpathname: '/mapbox-gl-js/api/',