-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glyphs #386
Glyphs #386
Conversation
Conflicts: js/text/placement.js
Conflicts: js/ui/map.js
Conflicts: js/ui/source.js
Conflicts: debug/site.js
Conflicts: js/text/placement.js
Conflicts: debug/site.js
Does not yet render the right sdfs.
@mikemorris I pushed a second fontstack ( Let's bulletproof your work today and make sure there are no regressions/differences in label density, etc. so that your branch can be merged. |
Glyphsproto err return
@mikemorris anything else you're seeing before you feel this is ready? |
Yes.
Yup. |
65280, // Specials | ||
65520, // Halfwidth and Fullwidth Forms | ||
65534 // Specials | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest separating all the glyphs stuff into a separate file, since workertile.js
gets too big.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mourner Agreed, at the very least this big array should probably live someplace else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, or the whole parseTextBucket method. It would also be nice to have a couple more comments along the code below.
Let's also resolve #388 before considering a merge. |
Conflicts: js/worker/workertile.js
Added basic text wrapping that only breaks on regular spaces (charcode 32). Controlled with: {
"text-max-width": 2, // em, default 15
"text-line-height": 1.4, // em, default 1.2
"text-alignment": "right", // default center
} |
"text-slant": 0.1 // shift one pixel to the right for every pixel up "text-slant": 0 // no slant
Unit is em
256 char range glyphs. Refs #388.
Not ready but opening PR for others to start to play with/review. Should be able to pull this down and get a working debug demo.
Will let @mikemorris write his notes here tomorrow.
cc @kkaefer