Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try different glyph range scenarios #388

Closed
yhahn opened this issue May 28, 2014 · 8 comments
Closed

Try different glyph range scenarios #388

yhahn opened this issue May 28, 2014 · 8 comments
Assignees

Comments

@yhahn
Copy link
Member

yhahn commented May 28, 2014

OTOH:

  • Current: based on unicode ranges
  • Split into 256 char chunks
  • Split into 1024 char chunks

I'll throw these in different prefixes on S3 for comparison and we can make llmr branches to try 'em out.

cc @kkaefer @mikemorris

@yhahn yhahn changed the title Try different range scenarios Try different glyph range scenarios May 28, 2014
@yhahn yhahn self-assigned this May 28, 2014
@yhahn
Copy link
Member Author

yhahn commented May 28, 2014

Available at:

http://mapbox.s3.amazonaws.com/gl-glyphs-256/{fontstack}/{range}.pbf
http://mapbox.s3.amazonaws.com/gl-glyphs-1024/{fontstack}/{range}.pbf

I rendered both of the current fontstacks:

  • Open Sans Regular, Arial Unicode MS Regular
  • Open Sans Semibold, Arial Unicode MS Regular

Here's gists with lists of the PBFs and sizes.

I can jump on setting up llmr branches to test these two different rangetypes out next.

cc @kkaefer @mikemorris

yhahn added a commit that referenced this issue May 28, 2014
@yhahn yhahn mentioned this issue May 28, 2014
@yhahn yhahn assigned ansis and unassigned yhahn May 28, 2014
@yhahn
Copy link
Member Author

yhahn commented May 28, 2014

@ansis I've pushed to both glyphs-256 and glyphs-1024 branches. I'm wondering how we want to actually make a decision here, like

  • Some kind of timed load/render of map at X with cache busting querystrings
  • Run this n times
  • Compare ?

Better ways to do this?

cc @mourner

@mourner
Copy link
Member

mourner commented May 29, 2014

@yhahn we could run the same animation smoothly covering a range of zoom levels (with long duration so that tiles are loaded in time), one for 256 and one for 1024, cache busted, and compare total traffic (filtered in dev tools to only measure glyph pbfs).

@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

Just switched to 256 in llmr-native with good results. mapbox/mapbox-gl-native@9939647

Wondering if for now we should go with that? I am a bit skeptical of putting a lot of priority on a perf comparison today and trying to come up with very conclusive results that we won't want to reexplore later : )

@ansis
Copy link
Contributor

ansis commented May 29, 2014

256 sounds good for now

@mikemorris
Copy link
Contributor

👍 to 256 for now, we may want to eventually do something like glyph ranges starting at the initial index of a unicode block and breaking in 256 glyph increments so that we don't randomly pull in unnecessary glyphs from nearby blocks. 1024 would be overkill for most blocks though.

@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

Great, we can refine/revisit/iterate on this after this cycle.

yhahn added a commit that referenced this issue May 29, 2014
256 char range glyphs. Refs #388.
@yhahn
Copy link
Member Author

yhahn commented Jun 4, 2014

Closing this down here -- will track further work upstream, e.g. mapbox/node-fontnik#36

@yhahn yhahn closed this as completed Jun 4, 2014
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants