Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4 changes #245

Merged
merged 113 commits into from
Apr 9, 2019
Merged

Version 4 changes #245

merged 113 commits into from
Apr 9, 2019

Conversation

scottsfarley93
Copy link

This PR contains all of the bug fixes and features described in #197.

Each change was tested, documented, and reviewed on its way into this PR.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

\cc @katydecorah @karenell

Scott Farley and others added 27 commits March 21, 2019 15:25
* update icons

* update css for input and icons, remove prefixes that are now obsolete

* if query selected, hide the clear button until the user hover over the control

* small design changes to result

* more item padding, rm border; lighter active bg

* remove active styles; does not infer item is active

* revert y padding on result items

* set spacing between input and results with calc, leave fallback

* hide input clear button in IE

* tidy css

* override system font

* use Assembly box-shadow

* inline svg

* increase right-padding on input

* add back active class

* sets a default `render` to create multiline results

* apply `text-overflow: ellipsis` to multiline results

Co-Authored-By: Andrew Harvey <[email protected]>

* style adjustments to account for collapsed option
Pass camera options to map.fitBounds
Map marker on selected result
Format changelog to highlight impact of each change
Minor documentation updates to improve clarity
@katydecorah katydecorah self-requested a review April 9, 2019 16:34
Copy link
Contributor

@katydecorah katydecorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, @scottsfarley93!

@scottsfarley93 scottsfarley93 merged commit 700a39a into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants