Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset this.lastSelected on clear #224

Merged
merged 2 commits into from
Mar 22, 2019
Merged

reset this.lastSelected on clear #224

merged 2 commits into from
Mar 22, 2019

Conversation

andrewharvey
Copy link
Collaborator

  • briefly describe the changes in this PR

Fixes an issue in #218 where lastSelected was not reset on clear.

  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • n/a update CHANGELOG.md with changes under master heading before merging

@andrewharvey andrewharvey added this to the v4.0.0 milestone Mar 21, 2019
scottsfarley93
scottsfarley93 approved these changes Mar 21, 2019
View reviewed changes
Copy link

@scottsfarley93 scottsfarley93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @andrewharvey. Changes look good to me!

@andrewharvey andrewharvey merged commit d8418cc into version4 Mar 22, 2019
@andrewharvey andrewharvey deleted the fix-dedup-result-event-workaround branch March 22, 2019 00:22
katydecorah pushed a commit that referenced this pull request Mar 22, 2019
Merge branch 'version4' into feedback
1018810 
* version4:
  reset this.lastSelected on clear (#224)
  [v4] style updates (#211)
  [v4] create collapsed option (#222)
  fixes double moveend event #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottsfarley93 scottsfarley93 scottsfarley93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewharvey @scottsfarley93