Replace some troublesome dependencies #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x-hull-2d with monotone-chain-convex-hull
|
The problem with this convex hull dependency is that it's not robust, so it will be inconsistent (convex hull non-robust while concaveman core algorithm robust).
Perhaps again a matter of putting coordinates in the right order when calling the orientation check? |
|
Rejigged again @mourner |
mourner
approved these changes
May 15, 2020
index.js
Outdated
| function convexHull(points) { | ||
| points.sort(function (a, b) { | ||
| return a[0] === b[0] ? a[1] - b[1] : a[0] - b[0]; | ||
| }); |
There was a problem hiding this comment.
Nit: I prefer to not inline anonymous functions wherever possible (this one could be extracted as compareByX to the top level).
index.js
Outdated
| orient(p1, q1, p2) > 0 !== orient(p1, q1, q2) > 0 && | ||
| orient(p2, q2, p1) > 0 !== orient(p2, q2, q1) > 0; | ||
| orient(p1[0], p1[1], q1[0], q1[1], p2[0], p2[1]) > 0 !== orient(p1[0], p1[1], q1[0], q1[1], q2[0], q2[1]) > 0 && | ||
| orient(p2[0], p2[1], q2[0], q2[1], p1[0], p1[1]) > 0 !== orient(p2[0], p2[1], q2[0], q2[1], q1[0], q1[1]) > 0; |
There was a problem hiding this comment.
Nit: now that you have cross shortcut below, you use that for less code.
mourner
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16
I did also do a before/after performance comparison and there seems to be negligible difference. If you're interested I'm happy to submit the benchmark setup I created with benchmarkjs.