-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump concaveman to 1.2.0 #95983
Bump concaveman to 1.2.0 #95983
Conversation
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @legrego , so I'm not familiar enough with yarn to know the intricacies.
this PR updates the yarn-file directly. Will this change be "remembered". e.g. suppose we bump @turf/center-of-mass
in the future, will it understand it needs to continue using at least concaveman 1.2.0
? Right now, I guess any will do https://github.com/Turfjs/turf/blob/master/packages/turf-convex/package.json#L61
@thomasneirynck yes, yarn will remember that we want version My reason for asking y'all for review is to make sure your usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
centerofmass is used to calculate label positions. CI stays green, so automatically verified. I tested in chrome and labels remain correctly positioned for both vector tile and json based rendering.
Co-authored-by: Larry Gregory <[email protected]>
Summary
Bumps
concaveman
to version1.2.0
. The previous version would not be compliant with a CSP which blocksunsafe-eval
.Notable change: mapbox/concaveman#17
This is a transitive dependency of
@turf/center-of-mass
. Ping @elastic/kibana-gis for review