Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump concaveman to 1.2.0 #95983

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

legrego
Copy link
Member

@legrego legrego commented Mar 31, 2021

Summary

Bumps concaveman to version 1.2.0. The previous version would not be compliant with a CSP which blocks unsafe-eval.

Notable change: mapbox/concaveman#17

This is a transitive dependency of @turf/center-of-mass. Ping @elastic/kibana-gis for review

@legrego legrego added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 31, 2021
@legrego legrego requested a review from a team March 31, 2021 19:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 761 754 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB -7.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @legrego , so I'm not familiar enough with yarn to know the intricacies.

this PR updates the yarn-file directly. Will this change be "remembered". e.g. suppose we bump @turf/center-of-mass in the future, will it understand it needs to continue using at least concaveman 1.2.0? Right now, I guess any will do https://github.com/Turfjs/turf/blob/master/packages/turf-convex/package.json#L61

@legrego
Copy link
Member Author

legrego commented Apr 1, 2021

this PR updates the yarn-file directly. Will this change be "remembered". e.g. suppose we bump @turf/center-of-mass in the future, will it understand it needs to continue using at least concaveman 1.2.0? Right now, I guess any will do Turfjs/turf@master/packages/turf-convex/package.json#L61

@thomasneirynck yes, yarn will remember that we want version 1.2.0. The only reason it would change is if @turf/center-of-mass started requiring a specific version that wasn't compatible with 1.2.0 -- at this point, I don't expect that to happen anytime soon, so I think we're OK from that perspective.

My reason for asking y'all for review is to make sure your usage of @turf/center-of-mass continues to work the way you expect it to. I have no domain knowledge here to know if what I'm looking at is accurate or not 😄

@legrego legrego added the Feature:Security/CSP Platform Security - Content Security Policy label Apr 1, 2021
@thomasneirynck thomasneirynck self-requested a review April 1, 2021 14:02
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centerofmass is used to calculate label positions. CI stays green, so automatically verified. I tested in chrome and labels remain correctly positioned for both vector tile and json based rendering.

@legrego legrego merged commit 37e2aa3 into elastic:master Apr 1, 2021
@legrego legrego deleted the chore/bump-concaveman branch April 1, 2021 14:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 1, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96055

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Security/CSP Platform Security - Content Security Policy release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants