Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate auth and environments packages to hashicorp/go-azure-sdk #217

Merged
merged 11 commits into from
Feb 23, 2023

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Feb 13, 2023

The auth and environments packages in the hashicorp/go-azure-sdk module now have feature parity with the packages here, so this migrates the SDK to these newer packages and removes the auth and environments packages from this module.

This is a breaking change, although with minimal disruption as can be seen from the changes to the test helpers in this PR.

Resolves: #169

Depends on: hashicorp/go-azure-sdk#306

@manicminer manicminer added breaking change Indicates a non-backwards compatible change refactor labels Feb 13, 2023
@manicminer manicminer added this to the v0.57.0 milestone Feb 13, 2023
@manicminer manicminer force-pushed the deps/migrate-auth-to-go-azure-sdk branch from 5fde1cc to dafa7b6 Compare February 14, 2023 20:57
@manicminer manicminer force-pushed the deps/migrate-auth-to-go-azure-sdk branch 2 times, most recently from 5e73fc9 to 5b57c36 Compare February 14, 2023 22:06
@manicminer manicminer modified the milestones: v0.57.0, v0.58.0 Feb 21, 2023
Copy link
Collaborator

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise 👍

go.mod Outdated Show resolved Hide resolved
@manicminer manicminer force-pushed the deps/migrate-auth-to-go-azure-sdk branch from 5b57c36 to 17b60c0 Compare February 23, 2023 08:45
@manicminer manicminer merged commit 486793b into main Feb 23, 2023
@manicminer manicminer deleted the deps/migrate-auth-to-go-azure-sdk branch February 23, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates a non-backwards compatible change refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Additional Azure Environments
2 participants