-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate auth and environments packages to hashicorp/go-azure-sdk #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
added
breaking change
Indicates a non-backwards compatible change
refactor
labels
Feb 13, 2023
manicminer
force-pushed
the
deps/migrate-auth-to-go-azure-sdk
branch
from
February 14, 2023 20:57
5fde1cc
to
dafa7b6
Compare
manicminer
force-pushed
the
deps/migrate-auth-to-go-azure-sdk
branch
2 times, most recently
from
February 14, 2023 22:06
5e73fc9
to
5b57c36
Compare
tombuildsstuff
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but otherwise 👍
manicminer
force-pushed
the
deps/migrate-auth-to-go-azure-sdk
branch
from
February 23, 2023 08:45
5b57c36
to
17b60c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
auth
andenvironments
packages in thehashicorp/go-azure-sdk
module now have feature parity with the packages here, so this migrates the SDK to these newer packages and removes theauth
andenvironments
packages from this module.This is a breaking change, although with minimal disruption as can be seen from the changes to the test helpers in this PR.
Resolves: #169
Depends on: hashicorp/go-azure-sdk#306