Remove authentication features in favor of go-azure-sdk/sdk/auth #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
manicminer
force-pushed
the
remove-auth-features
branch
4 times, most recently
from
f4cb642 to
506f4b7
Compare
manicminer
force-pushed
the
remove-auth-features
branch
from
506f4b7 to
db006dd
Compare
tombuildsstuff
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashicorp/terraform-provider-azurerm#20320 removes use of the go-azure-helpers/authentication package in favor of the new SDK's own auth package, except for the two remaining helper functions which are left in here.
Additionally, rework the helper functions for obtaining the authenticated principal's object IDDepends on manicminer/hamilton#217 before merging