fix: Correct mamba env export --json --from-history
#3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
changed the title
mamba env export --json --from-historymamba env export --json --from-history
jjerphan
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Thank you for this contribution, @mathbunnyru.
Could you add a non-regression test?
mathbunnyru
commented
Nov 12, 2024
| output = helpers.run_env("export", "-n", export_env, "--from-history", *flags) | ||
|
|
||
| # json is already parsed | ||
| ret = output if json_flag else yaml.safe_load(output) |
There was a problem hiding this comment.
@jjerphan I added a test and checked this line fails in the current main and this tests passes in my branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3582