Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mamba 2 breaks Jupyter docker-stacks #3506

Closed
JohanMabille opened this issue Oct 4, 2024 · 12 comments
Closed

mamba 2 breaks Jupyter docker-stacks #3506

JohanMabille opened this issue Oct 4, 2024 · 12 comments

Comments

@JohanMabille
Copy link
Member

See details
@mathbunnyru
Copy link
Contributor

mathbunnyru commented Oct 23, 2024 •
edited
Loading

I think this is now the only issue which prevents Jupyter Docker Stacks from switching to v2: #3503

As far as I see, conda-libmamba-solver is now compatible with v2, so we're waiting for the new version to be released.
And also waiting for a new release of mamba, to include fixes made here.

@mathbunnyru
Copy link
Contributor

One more issue preventing us from updating: #3582
I submitted the fix: #3590

philroche added a commit to philroche/os that referenced this issue Nov 14, 2024
@philroche
fix(py3-conda-libmamba-solver): Cherrypick upstream commits to add su…
02513ae 
…pport for libmamba 2.0

We have already released packages updates to libmamba and subpackages which is a major version jump from 1.5 to 2.0.

This caused failures in the conda packages and images due to py3-conda-libmamba-solver not yet supporting libmamba 2.0.

There is not yet an upstream release of conda-libmamba-solver with mamba 2.0 support for there is a release candidate
branch @ https://github.com/conda/conda-libmamba-solver/tree/24.11.0rc awaiting release.

We have broken dependent packages so we cannot wait for upstream to release.

As such I have cherrypicked the relevant 2.0 support commits from the 24.11.0rc branch.

This resolves the issues seen with conda and libmamba.

Full diff for conda-libmamba-solver @  conda/conda-libmamba-solver@24.9.0...24.11.0rc

mamba-org/mamba#3506 was the most helpful in finding the work to support libmamba 2.0
Signed-off-by: philroche <[email protected]>
philroche added a commit to philroche/os that referenced this issue Nov 14, 2024
@philroche
fix(py3-conda-libmamba-solver): Cherrypick upstream commits to add su…
51f2dee 
…pport for libmamba 2.0

We have already released packages updates to libmamba and subpackages which is a major version jump from 1.5 to 2.0.

This caused failures in the conda packages and images due to py3-conda-libmamba-solver not yet supporting libmamba 2.0.

There is not yet an upstream release of conda-libmamba-solver with mamba 2.0 support for there is a release candidate
branch @ https://github.com/conda/conda-libmamba-solver/tree/24.11.0rc awaiting release.

We have broken dependent packages so we cannot wait for upstream to release.

As such I have cherrypicked the relevant 2.0 support commits from the 24.11.0rc branch.

This resolves the issues seen with conda and libmamba.

Full diff for conda-libmamba-solver @  conda/conda-libmamba-solver@24.9.0...24.11.0rc

mamba-org/mamba#3506 was the most helpful in finding the work to support libmamba 2.0
Signed-off-by: philroche <[email protected]>
@philroche philroche mentioned this issue Nov 14, 2024
Merged
philroche added a commit to wolfi-dev/os that referenced this issue Nov 14, 2024
@philroche
fix(py3-conda-libmamba-solver): Cherrypick upstream commits to add su…
d68acd7 
…pport for libmamba 2.0 (#34145)

We have already released packages updates to libmamba and subpackages
which is a major version jump from 1.5 to 2.0.

This caused failures in the conda packages and images due to
py3-conda-libmamba-solver not yet supporting libmamba 2.0.

There is not yet an upstream release of conda-libmamba-solver with mamba
2.0 support but there is a release candidate
branch @ https://github.com/conda/conda-libmamba-solver/tree/24.11.0rc
awaiting release.

We have broken dependent packages so we cannot wait for upstream to
release.

As such I have cherrypicked the relevant 2.0 support commits from the
24.11.0rc branch.

This resolves the issues seen with conda and libmamba.

Full diff for conda-libmamba-solver @
conda/conda-libmamba-solver@24.9.0...24.11.0rc

mamba-org/mamba#3506 was the most helpful in
finding the work to support libmamba 2.0
Signed-off-by: philroche <[email protected]>

Signed-off-by: philroche <[email protected]>
dannf pushed a commit to dannf/os that referenced this issue Nov 15, 2024
@philroche @dannf
fix(py3-conda-libmamba-solver): Cherrypick upstream commits to add su…
664f51d 
…pport for libmamba 2.0 (wolfi-dev#34145)

We have already released packages updates to libmamba and subpackages
which is a major version jump from 1.5 to 2.0.

This caused failures in the conda packages and images due to
py3-conda-libmamba-solver not yet supporting libmamba 2.0.

There is not yet an upstream release of conda-libmamba-solver with mamba
2.0 support but there is a release candidate
branch @ https://github.com/conda/conda-libmamba-solver/tree/24.11.0rc
awaiting release.

We have broken dependent packages so we cannot wait for upstream to
release.

As such I have cherrypicked the relevant 2.0 support commits from the
24.11.0rc branch.

This resolves the issues seen with conda and libmamba.

Full diff for conda-libmamba-solver @
conda/conda-libmamba-solver@24.9.0...24.11.0rc

mamba-org/mamba#3506 was the most helpful in
finding the work to support libmamba 2.0
Signed-off-by: philroche <[email protected]>

Signed-off-by: philroche <[email protected]>
@jjerphan
Copy link
Member

jjerphan commented Dec 2, 2024

@mathbunnyru: should we close this issue now that mamba 2 can be used?

@mathbunnyru
Copy link
Contributor

I'm working on it :)

@mathbunnyru
Copy link
Contributor

I found one more difference between v1 and v2

v2:

(base) jovyan@27933482a351:~$ mamba env export --no-build --json --from-history
{
  "channels": [
    "conda-forge"
  ],
  "dependencies": [
    "conda",
    "jupyter_core",
    "jupyterhub-singleuser",
    "jupyterlab",
    "mamba",
    "nbclassic",
    "notebook>=7.2.2",
    "python=3.12"
  ],
  "name": "base",
  "prefix": "/opt/conda"
}

v1:

(base) jovyan@c5da4bba1d79:~$ mamba env export --no-build --json --from-history
{
  "channels": [
    "conda-forge"
  ],
  "dependencies": [
    "jupyter_core",
    "mamba[version='<2.0.0']",
    "python=3.12",
    "jupyterhub-singleuser",
    "jupyterlab",
    "nbclassic",
    "notebook[version='>=7.2.2']",
    "ca-certificates",
    "certifi",
    "openssl"
  ],
  "name": "base",
  "prefix": "/opt/conda"

@mathbunnyru
Copy link
Contributor

Note the line with notebook.

v2's output is not compatible with conda's output when some lib was installed specifying version range

@mathbunnyru
Copy link
Contributor

We only use this in testing our images, so I will change the way we do it in docker-stacks.
But I still think it should be fixed (to be compatible with conda).

@jjerphan
Copy link
Member

jjerphan commented Dec 2, 2024

Let's open a dedicated issue for this?

@mathbunnyru
Copy link
Contributor

Let's open a dedicated issue for this?

Yes, was just doing that 🙂

@mathbunnyru
Copy link
Contributor

Done: #3646

@mathbunnyru
Copy link
Contributor

I will merge v2 in docker-stacks tomorrow. I don't think it makes sense to keep this issue open. If something comes up, I will create separate issues.

@mathbunnyru
Copy link
Contributor

@JohanMabille @jjerphan could you please close this issue?

@jjerphan jjerphan closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohanMabille @mathbunnyru @jjerphan