Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

update migrations plugin with changes from migrate-dashboard #233

Merged
merged 2 commits into from
May 26, 2020

Conversation

levity
Copy link
Contributor

@levity levity commented May 23, 2020

No description provided.

@levity levity marked this pull request as ready for review May 23, 2020 00:13
@levity levity requested review from ethanbennett and jparklev May 23, 2020 00:13
@levity
Copy link
Contributor Author

levity commented May 23, 2020

this creates a conflict with #231; sorry about that @jparklev

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #233 into dev will decrease coverage by 1.38%.
The diff coverage is 39.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #233      +/-   ##
==========================================
- Coverage   86.35%   84.96%   -1.39%     
==========================================
  Files         128      130       +2     
  Lines        3737     3812      +75     
==========================================
+ Hits         3227     3239      +12     
- Misses        510      573      +63     
Impacted Files Coverage Δ
...ages/dai-plugin-migrations/src/MigrationService.js 100.00% <ø> (ø)
packages/dai-plugin-migrations/src/constants.js 100.00% <ø> (ø)
...ions/src/migrations/GlobalSettlementDaiRedeemer.js 14.63% <0.00%> (-85.37%) ⬇️
...ugin-migrations/src/migrations/SingleToMultiCdp.js 73.01% <25.00%> (-24.86%) ⬇️
...src/migrations/GlobalSettlementCollateralClaims.js 65.71% <52.00%> (-34.29%) ⬇️
...tions/src/migrations/GlobalSettlementSavingsDai.js 100.00% <100.00%> (ø)
...ugin-migrations/src/migrations/RedeemCollateral.js 100.00% <100.00%> (ø)
.../dai-plugin-migrations/src/migrations/RedeemSai.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7576507...726c5c0. Read the comment docs.

@@ -8,7 +8,7 @@ CONTRACTS=$CWD/../contracts
SOURCE=${1:-$CWD/../../../node_modules/@makerdao/testchain}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanbennett i wasn't 100% sure i merged the changes here correctly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levity yep, just tested it and it works 👍

@levity levity merged commit a624aca into dev May 26, 2020
@levity levity deleted the update-migration-plugin branch May 26, 2020 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants