Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

require abis in abi maps #231

Merged
merged 5 commits into from
May 27, 2020
Merged

require abis in abi maps #231

merged 5 commits into from
May 27, 2020

Conversation

jparklev
Copy link
Contributor

@jparklev jparklev commented May 22, 2020

This

  • lets us catch missing abis at build-time
  • ensures any bundlers with aggressive tree shaking bundle the right abis

Also, MCD_MOVE_* and MCD_MOVE_DAI seemed to be missing abis, but it didn't look like they were being used anywhere?

Copy link
Contributor

@levity levity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM. maybe add a comment in abiMap.js, or in a contracts/README, to note that this part of the project tree doesn't get run through Babel so it needs to be ES5

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #231 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #231   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files         130      130           
  Lines        3807     3807           
=======================================
  Hits         3234     3234           
  Misses        573      573           
Impacted Files Coverage Δ
packages/dai-plugin-mcd/src/index.js 100.00% <100.00%> (ø)
packages/dai-plugin-migrations/src/index.js 100.00% <100.00%> (ø)
packages/dai-plugin-scd/src/index.js 95.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0840241...8068d57. Read the comment docs.

@jparklev
Copy link
Contributor Author

@levity resolved conflicts from #233 and added comments :)

@levity
Copy link
Contributor

levity commented May 27, 2020

Approved again :)

@jparklev jparklev merged commit 9f7e374 into dev May 27, 2020
@jparklev jparklev deleted the abiMap-require branch May 28, 2020 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants