Merge branch 'ranked-choice-methods' of https://github.com/makerdao/d…

…ai.js into ranked-choice-methods
makerdao · May 11, 2020 · 678aeac · 678aeac
2 parents 40f6b56 + 99a7797
commit 678aeac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/dai-plugin-governance/package.json b/packages/dai-plugin-governance/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@makerdao/dai-plugin-governance",
   "description": "A dai.js plugin for adding MKR governance support to dapps.",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "license": "MIT",
   "repository": {
     "type": "git",

diff --git a/packages/dai-plugin-governance/src/GovPollingService.js b/packages/dai-plugin-governance/src/GovPollingService.js
@@ -214,9 +214,10 @@ export default class GovPollingService extends PrivateService {
         let maxOption;
         Object.entries(tally.options).forEach(
           ([option, { firstChoice, transfer }]) => {
-            if (firstChoice.plus(transfer).gt(max))
+            if (firstChoice.plus(transfer).gt(max)) {
               max = firstChoice.plus(transfer);
-            maxOption = option;
+              maxOption = option;
+            }
           }
         );
         tally.winner = maxOption;