filter out eliminated vote options for irv

makerdao · May 11, 2020 · 40f6b56 · 40f6b56
1 parent e0a5350
commit 40f6b56
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/dai-plugin-governance/src/GovPollingService.js b/packages/dai-plugin-governance/src/GovPollingService.js
@@ -167,8 +167,9 @@ export default class GovPollingService extends PrivateService {
       tally.rounds++;
 
       // eliminate the weakest candidate
-      const [optionToEliminate] = Object.entries(tally.options).reduce(
-        (prv, cur) => {
+      const [optionToEliminate] = Object.entries(tally.options)
+        .filter(([, optionDetails]) => !optionDetails.eliminated)
+        .reduce((prv, cur) => {
           const [, prvVotes] = prv;
           const [, curVotes] = cur;
           if (
@@ -178,8 +179,7 @@ export default class GovPollingService extends PrivateService {
           )
             return cur;
           return prv;
-        }
-      );
+        });
 
       tally.options[optionToEliminate].eliminated = true;
       tally.options[optionToEliminate].transfer = BigNumber(0);