fix authentication #316
Merged
fix authentication #316
+153
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple has introduced some dynamic GET parameters into their redirects, forcing us to use the main domain ( no `p71-` and such prefixes ) to obtain those parameters. However, when following such redirects, we shall also increment the `attempt` parameter ( something that was hard-coded before ).
|
Without the 2FA code, it works fine. Have you tested the two-step verification scenario? I tested the two-step verification, and it prompted twice for a verification code. After entering the first code with an error response, it then showed the second prompted verification code, but the main process had exited with an error. Is there something wrong? 
|
|
@mooring have you used it with |
|
Great contribution! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple has introduced some dynamic GET parameters into their redirects, forcing us to use the main domain ( no
p71-and such prefixes ) to obtain those parameters.However, when following such redirects, we shall also increment the
attemptparameter ( something that was hard-coded before ).