Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ember qunit less than v6 #2031

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Drop ember qunit less than v6 #2031

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a74853
Drop support for ember-qunit v4 + v5
NullVoxPopuli Sep 27, 2023
794a4a5
Update README
NullVoxPopuli Sep 27, 2023
4da8be1
reduceLock
NullVoxPopuli Sep 27, 2023
c055294
Use super old pnpm, 7.33.6, as specified by CI
NullVoxPopuli Sep 27, 2023
1307151
Remove all the support infra for older ember-qunit in the index.js, a…
NullVoxPopuli Sep 28, 2023
7e612d7
Add note about older ember-qunit in the README
NullVoxPopuli Sep 28, 2023
c95fafd
No need to use macros in teh test app
NullVoxPopuli Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ jobs:
matrix:
embroider: ["true", "false"]
ember-try-scenario:
- ember-qunit-4
- ember-qunit-5
- ember-lts-3.28
- ember-lts-4.12

steps:
- uses: actions/[email protected]
Expand Down
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ or using [`yarn`](https://yarnpkg.com/):
yarn add --dev qunit-dom
```

### Ember projects using `ember-qunit` v5.x and above
### Ember projects using `ember-qunit` v6.x and above

Import and run the `setup` function in your `test-helper.js` file:

Expand All @@ -59,10 +59,6 @@ start();

This will attach the APIs to QUnit's `assert` object.

### Ember projects using `ember-qunit` v4.x and below

`qunit-dom` will automatically attach the APIs to QUnit's `assert` object. No extra setup required :tada:.

### `<script>` Tag

Load `qunit-dom.js` *after* `qunit.js`:
Expand Down
Loading