Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for making the v2 conversion flow, starting in #2027 easier, I'm extracting some of the more isolated changes.
For an overall plan for how v2 addon conversion works,
Also, in part, to help with maintenance burden, supporting less is easier as well. ember-qunit is on v8 now, and v4 and v5 are very old and have "magic" build-time behavior, which can't be transferred to the v2 addon world.
Up next will be upgrading the embroider deps, because < v3 isn't really supported 🙃
Outstanding questions for the maintainers:
Things to keep in mind: In my subsequent PRs to qunit-dom, there may be more breaking changes. I'll make sure each is called out in the PR that introduces them, if not extracted to a separate PR (which would be my preference, depending on the situation that calls for the change)