Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Caching + Fix Tests + Updates #22

Merged
merged 4 commits into from
Sep 5, 2016

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Aug 31, 2016

This PR fixes a number of things:

Tests

The test suite was failing because it wasn't stripping test selectors for tests. Adding a configuration to strip the selectors causes the test suite to pass now.

Version Compatibility

I implemented version compatibility testing to get us better coverage.

Caching Strategy

I reported in #19 that there is a deprecation warning about the addon not providing a caching strategy. This was actually pretty easy to fix based on examples.

Ember CLI Upgrade

We were using 2.3.0-beta so I upgraded to the latest (2.7.0) and ran ember init.

Test selectors were not marked to be removed in test, breaking the
build.
This silences the deprecation warning reported in mainmatter#19.
I found this solution
[here](ember-animation/liquid-fire#485)
@blimmer blimmer force-pushed the chore/fix-caching branch from 063b04b to 2304792 Compare August 31, 2016 00:14
@blimmer blimmer force-pushed the chore/fix-caching branch from 2304792 to e184ca4 Compare August 31, 2016 00:16
@blimmer
Copy link
Contributor Author

blimmer commented Aug 31, 2016

cc @pangratz

@pangratz
Copy link
Contributor

😍 awesome work here @blimmer! Thanks so much for tackling this!

This LGTM, but I leave this for @marcoow to merge and cut a new release...

@marcoow marcoow merged commit cd01e97 into mainmatter:master Sep 5, 2016
@marcoow
Copy link
Member

marcoow commented Sep 5, 2016

awesome - thanks 🎉

@Turbo87 Turbo87 added the bug label Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants